Conversation
jmtts
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large structured WebSocket responses currently fail at the server's 128 KiB limit. This is the client prerequisite for W24-Service-GmbH/core-reader#2055: recognize
payload_encoding: "json", download and decrypt the existingpayload_url, and deserialize its JSON intopayload_dictusing the same v1/v2 response models as inline results. Unmarked downloads—including JSON files—remain inpayload_bytes; malformed structured JSON fails explicitly.Prepare version 2.9.0 so the server can gate offloading on a reported client version that supports this contract. Release this client before enabling the companion server change (https://github.com/W24-Service-GmbH/core-reader/pull/2535). Upgrade crew-api's client dependency to 2.9.0 when rolling out synchronous HTTP support: the result is reconstructed before that adapter clears
payload_bytes. Older clients retain the existing explicit oversize failure rather than silently receiving data in a different field.Validation: 71 tests passed across structured offloads, shared HTTPS/download ordering, read deadlines/retries, and callback contracts. Includes typed v1 PMI and v2 round trips, a large Unicode payload, binary compatibility, corrupt JSON, and preservation through the synchronous HTTP adapter's serialization behavior. Ruff and whitespace checks passed. Tests ran on Python 3.12.8; no live S3 or production deployment was performed.