Expose structured ISO 9013 cut quality on roughness - #604
Merged
Merged
Conversation
werk24
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
thermal_cut_qualityto both roughness model generations. It carries the ISO 9013 standard and nullable perpendicularity/angularity range, Rz5 range and tolerance class, so consumers can use the designation without parsing manufacturing-process text.Existing payloads remain valid because the field defaults to null. The existing text fields are unchanged. Designation values are single digits; absent values are not inferred.
This PR is stacked on #602 so its model additions remain available. The diff against that branch contains only thermal-cut-quality models and tests.
Validation: full offline SDK suite passed on Python 3.14: 1,027 tests passed, one callback end-to-end test deselected. This includes 10 focused tests for serialization, nullable fields, schema compatibility and digit validation.
Questions for the owner
None. No decision blocks the merge.