Repository navigation
Name both size limits in RequestTooLargeException's message - #608
Merged
Merged
Conversation
The message said the limit is 10MB, but RequestTooLargeException is also the parent of the callback exceptions, whose limit is about 4.6 MB for the whole request. It now names both: 10 MiB for a drawing sent with read_drawing, about 4.6 MB for a callback request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Udr9ePHq9JKa6ZtgjuRbi5
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The message accurately reflects the existing limits without changing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the generic oversized-request message to distinguish drawing and callback size limits.
Changes:
- Names the 10 MiB drawing limit.
- Names the approximate 4.6 MB callback-request limit.
| File | Description |
|---|---|
werk24/utils/exceptions.py |
Clarifies RequestTooLargeException guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jmtts
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestTooLargeExceptionsaid "maximum allowed size of 10MB". It is also the parent of the callback exceptions, whose limit is about 4.6 MB for the whole request. The message now names both: 10 MiB for a drawing sent withread_drawing, about 4.6 MB for a callback request. The message text is the only change; no model or behaviour changes.Checks run
pytest -m "not callback_e2e": 1023 passed, 4 skipped (the live tests, no credentials here).Questions for the owner
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Udr9ePHq9JKa6ZtgjuRbi5
Generated by Claude Code