Don't skip MoorDyn tests#105
Open
jtgrasb wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
The tests are still failing intermittently and causing MATLAB to crash even though they pass locally. Speaking with @akeeste, we decided to skip the tests entirely and continue to test locally when changes are made. Potential causes include lack of compatibility between dll and github os, dll renaming, file skipping, etc. but these are not worth time at this stage. |
Contributor
Author
|
Jeff to do: Skip the individual tests including MoorDyn rather than entire folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MoorDyn tests shouldn't fail anymore due to the v2.5 updates.
The tests are still skipped on Linux/Ubuntu because the MoorDyn folder is set up so that the specific architecture needs to be selected manually.