Fix #104: [milestone Milestone 4 ] Add schemas/aep/memory-evidence.schema.json — tamper-evident memory read/wri... - #105
Fix #104: [milestone Milestone 4 ] Add schemas/aep/memory-evidence.schema.json — tamper-evident memory read/wri...#105telleroutlook wants to merge 1 commit into
schemas/aep/memory-evidence.schema.json — tamper-evident memory read/wri...#105Conversation
…chema.json` — tamper-evident memory read/wri...
SummaryClean additive PR: new MemoryEvidence schema with index registration, valid/invalid fixtures, and a pytest conformance wrapper; no blockers. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Clean additive PR: new MemoryEvidence schema with index registration, valid/invalid fixtures, and a pytest conformance wrapper; no blockers.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 6,
"issue": "Root object omits additionalProperties:false while the nested signature object enforces it; for a tamper-evident record this permits unexpected top-level fields the optional signature may not cover.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 1
} |
|
Merge gate failed: |
SummaryAdditive PR adds a well-formed MemoryEvidence schema with valid/invalid fixtures and a pytest wrapper for the existing conformance harness; no compile errors, no test weakening, no API break. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Additive PR adds a well-formed MemoryEvidence schema with valid/invalid fixtures and a pytest wrapper for the existing conformance harness; no compile errors, no test weakening, no API break.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 8,
"issue": "Top-level object omits additionalProperties: false even though the nested signature object sets it (line 25); for a tamper-evident evidence record, unexpected top-level fields will silently validate, which is inconsistent with the stricter nested envelope.",
"kind": "suggestion"
},
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 13,
"issue": "digest and prior_digest are unstructured strings with no pattern/format constraint (e.g. a ^sha256:[0-9a-f]{64}$ regex), so malformed digests like 'base64sig==' or arbitrary text will pass validation.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 2
} |
|
Merge gate failed: |
SummaryPR adds a new memory-evidence schema with consistent valid/invalid fixtures and a pytest conformance wrapper; all changes are additive and self-consistent. Severitynone Blocking findingsNone. Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "none",
"summary": "PR adds a new memory-evidence schema with consistent valid/invalid fixtures and a pytest conformance wrapper; all changes are additive and self-consistent.",
"findings": [],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 3
} |
|
Merge gate failed: |
SummaryClean additive PR: new MemoryEvidence schema with index registration, correctly-formed valid/invalid fixtures, and a pytest conformance wrapper; no blockers. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Clean additive PR: new MemoryEvidence schema with index registration, correctly-formed valid/invalid fixtures, and a pytest conformance wrapper; no blockers.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 27,
"issue": "Top-level schema omits additionalProperties:false (only the signature sub-object enforces it); for a tamper-evident evidence record, unexpected fields would silently validate.",
"kind": "suggestion"
},
{
"file": "package-lock.json",
"line": 1,
"issue": "New package-lock.json carries only package metadata with no resolved dependencies; appears unrelated to the schema additions and may be a stray artifact.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 4
} |
|
Merge gate failed: |
SummaryAdditive schema registration with valid/invalid fixtures and a pytest wrapper; no blockers identified. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Additive schema registration with valid/invalid fixtures and a pytest wrapper; no blockers identified.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 6,
"issue": "Root object declares type:object but omits additionalProperties:false, while the nested signature object enforces it — inconsistent strictness that permits stray top-level fields.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 5
} |
|
Merge gate failed: |
SummaryPR adds the MemoryEvidence AEP schema with valid/invalid fixtures and a pytest conformance wrapper; no blockers, only minor schema-hardening suggestions. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "PR adds the MemoryEvidence AEP schema with valid/invalid fixtures and a pytest conformance wrapper; no blockers, only minor schema-hardening suggestions.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 10,
"issue": "Top-level object lacks `additionalProperties: false`; for a record described as tamper-evident/non-repudiable, leaving the root open permits unexpected fields the signature envelope would then have to cover ambiguously. The nested `signature` object correctly locks this down (line 21), but the root does not.",
"kind": "suggestion"
},
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 11,
"issue": "Schema uses required field `timestamp_ms`, but schemas/index.json describes the shared AEP envelope base as carrying `created_at_ms`; if MemoryEvidence is meant to share that envelope, the field-name divergence (and absence of `created_at_ms`) should be reconciled or documented as intentional.",
"kind": "suggestion"
},
{
"file": "tests/test_conformance.py",
"line": 20,
"issue": "`import conformance` depends on tests/conformance.py existing out-of-diff; the module is not shown here, so a missing/stale file would surface as an ImportError at collection time — verify it is present in the target branch.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 6
} |
|
Merge gate failed: |
SummaryAdditive PR adding the MemoryEvidence AEP schema, an index entry, valid/invalid fixtures, and a pytest conformance wrapper; no blockers found. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Additive PR adding the MemoryEvidence AEP schema, an index entry, valid/invalid fixtures, and a pytest conformance wrapper; no blockers found.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 6,
"issue": "Root object omits additionalProperties: false while the nested signature object enforces it, so unknown top-level fields would pass validation silently on a tamper-evident record.",
"kind": "suggestion"
},
{
"file": "tests/test_conformance.py",
"line": 20,
"issue": "Imports the conformance module (tests/conformance.py) which is not present in this diff; if it is not already in the repo, pytest collection fails with ImportError.",
"kind": "suggestion"
},
{
"file": "package-lock.json",
"line": 1,
"issue": "Introduces a new minimal npm lockfile at the root of an otherwise Python/schema project; confirm npm tooling is intended here.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 7
} |
|
Merge gate failed: |
SummaryClean additive PR registering the MemoryEvidence schema with matching valid/invalid fixtures and a pytest conformance wrapper; no blockers, only minor suggestions. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Clean additive PR registering the MemoryEvidence schema with matching valid/invalid fixtures and a pytest conformance wrapper; no blockers, only minor suggestions.",
"findings": [
{
"file": "tests/test_conformance.py",
"line": 17,
"issue": "Imports the `conformance` module which is not shown in this diff; if tests/conformance.py is not already present in the repo, pytest collection will fail with ImportError.",
"kind": "suggestion"
},
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 6,
"issue": "Root object does not set additionalProperties:false while the nested signature object does; decide intentionally whether unknown top-level fields should be rejected for this evidence record.",
"kind": "suggestion"
},
{
"file": "package-lock.json",
"line": 1,
"issue": "New package-lock.json introduced for @wasmagent/protocol@0.1.5 with no declared dependencies; per policy lock-file-only changes are suggestion-level, but confirm tracking this file aligns with the repo's existing build setup.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 8
} |
|
Merge gate failed: |
SummaryClean additive PR: new MemoryEvidence schema with matching valid/invalid fixtures, index registration, and a pytest conformance wrapper; no blockers. Severitylow Blocking findings
Verdict✅ Approved Merge risklow Audit
{
"approved": true,
"severity": "low",
"summary": "Clean additive PR: new MemoryEvidence schema with matching valid/invalid fixtures, index registration, and a pytest conformance wrapper; no blockers.",
"findings": [
{
"file": "schemas/aep/memory-evidence.schema.json",
"line": 8,
"issue": "Top-level object omits additionalProperties:false while the nested signature object enforces it, allowing unexpected keys on the evidence record itself; inconsistent strictness.",
"kind": "suggestion"
}
],
"merge_risk": "low",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 9
} |
|
Merge gate failed: |
|
Superseded by PR #152, which adds memory-evidence.schema.json with a more complete implementation. Closing the older version to avoid duplicates. |
Fixes #104
Generated by claude-bot-go worker.