Fix #139: [milestone Milestone 4] Create evidence-envelope AEP schema - #143
Closed
telleroutlook wants to merge 2 commits into
Closed
Fix #139: [milestone Milestone 4] Create evidence-envelope AEP schema#143telleroutlook wants to merge 2 commits into
telleroutlook wants to merge 2 commits into
Conversation
…schema Add the evidence-type discriminator, payload object (with contents), and metadata key-value map to the evidence-envelope schema so it fully covers the acceptance criteria for #139: - evidence_type (required): discriminator for the evidence kind - payload (required): the evidence content, structure depends on type - metadata (optional): arbitrary key-value metadata about the record Update the valid fixture to include the new required fields. The invalid fixture remains valid (missing created_at_ms, which is still required). All 22 pytest + 18 JS conformance tests pass. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
SummaryClean schema refactor that introduces base schema composition, but new required fields (evidence_type, payload) may constitute a breaking API change not documented in issue #143 Severitylow Blocking findings
Verdict✅ Approved Merge riskmedium Audit
{
"approved": true,
"severity": "low",
"summary": "Clean schema refactor that introduces base schema composition, but new required fields (evidence_type, payload) may constitute a breaking API change not documented in issue #143",
"findings": [
{
"file": "schemas/aep/evidence-envelope.schema.json",
"line": 10,
"issue": "Public API break: adds required fields 'evidence_type' and 'payload' via allOf composition - existing evidence envelopes without these fields would no longer validate",
"kind": "suggestion"
}
],
"merge_risk": "medium",
"Model": "opus",
"model": "claude-cli",
"effort": "high",
"tokens": {
"input_tokens": 0,
"output_tokens": 0
},
"same_verdict_count": 1
} |
Contributor
Author
|
Closing: GitHub CI failed. Bot will reimplement with CI failure context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139
Generated by claude-bot-go worker.