Add native macOS RoboStack setup - #12
Merged
Merged
Conversation
run_workspace spawned a new `bash -c`, which does not inherit the script's `set -euo pipefail`. A failing `cd` or a failing `source install/setup.bash` was therefore ignored, and the user's command still ran without the workspace overlay while the helper reported success (exit 0). Guard both steps explicitly so the helper aborts with an actionable message instead of silently running commands against the wrong environment. Explicit guards are used rather than `set -e` because `set -u` breaks ROS's generated setup.bash (COLCON_TRACE unbound) and `set -e` would propagate into that sourced script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
./scripts/macos.sh setupcreated the environment and built all three packages./scripts/macos.sh launchstarted robot state publisher, Joint State Publisher GUI, and RViz; the robot initializedshellcheck scripts/macos.shpassedbash -n scripts/macos.shpassedKnown test behavior
The existing bringup launch teardown assertion can report robot state publisher exit
-6on macOS after SIGINT instead of the allowed0or-2. Runtime startup and the live launch smoke test pass. This PR does not change that test or runtime node.