Publish a release without waiting for macOS, compile weft once per release - #47
Merged
Merged
Conversation
…lease, and let a fresh install's first upload wait for its grant - The release's Linux legs build the CLI, the runtime and the images in one job; the runtime image takes the runtime binary that job built (`weft build-images --runtime-binary`, checked by starting it in the image) instead of compiling it again in Docker. - The macOS binaries are their own job and join the latest release afterwards, so the release, the manifest and every fork waiting on it no longer wait for the Intel runner. - The manifest names the source tree; setup.sh, the GCP install and the project deploy workflow match on it, so a fork that merged weft unchanged downloads instead of compiling. - scripts/release-cli.sh fetches the release's CLI for a checkout, waiting while upstream's release for that source is still building; a fork that has to build keeps its dependencies cached between runs. - Only main saves Rust caches; after each release one copy per job is kept and the rest deleted. - The AWS SDK uses ring like every other TLS client; aws-lc is gone. - Signing a storage link waits up to ten minutes for a new install's grant to take effect, through the IAM settle helper, now given a patience per change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Release speed
weft-runtimebinary that job just built (weft build-images --runtime-binary) instead of compiling it again inside Docker. That used to be about 13 minutes with no cache. The image job no longer compiles a debug CLI either.release-macosadds the Mac binaries afterwards. The Intel runner took over 50 minutes cold today and held up the whole release.Caches
mainsaves Rust caches; PR runs read main's copy and save nothing.prune-cacheskeeps the newest copy of each job's cache and deletes the older ones.Forks and project deploys
manifest.jsonnow names the source tree.setup.sh, the GCP install and the project deploy workflow match on that tree. A fork that merged weft without changes gets a different commit with the same files, and now downloads instead of compiling.scripts/release-cli.shfetches the release's CLI for a checkout. If upstream's release for that source is still building, it waits for it instead of compiling.Fresh-install upload failure
Crypto
ringfor TLS like every other client;aws-lc-sysandaws-lc-rsare gone.Tested
weft-cli,weft-platform-traits,weft-core,weft-platform-gcpandweft-brokerpass.storage::fetched_file_is_stored_and_downloadableandstorage_multipart::multipart_uploads_round_trip_across_sizespass.Not tested yet:
main. The newlinuxandmacosjobs start with empty caches, so that first release compiles everything once.setup.shcompile once during that run.