Repository navigation
Conversation
…ing, let a start finish once accepted, and name what an export sets - A copy being started counts from when the start was asked (the setup run or the apply command), the earlier of that and its row's stamp, and the duration is read on the install's clock (ApplyProgress and unanswered calls carry as_of_unix), so a reader's clock drift no longer shifts it. - A running container whose readiness check fails within its startup window (initial delay plus period times failure threshold, from the probe) reads as starting, not as the raw error; past it the raw error shows as before. - ctx.infra(..).request_start() returns once weft accepts the start; start() is that plus the wait until running. StartInstanceInfra gains waitUntilRunning (default on), so a route can start and then reply 202 with the copy already listed as provisioning. Docs and Tangle teach start, then reply. - weft target export names each secret it set (never a value), and the next-step hint adds --front-env front/.env.prod when that file exists, or says what the flag is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from Tangle's round 12.
--front-env front/.env.prodwhen that file exists, or says what the flag is for.weft target exportnames each secret it set (never a value).asOfUnixonApplyProgressand unanswered calls).ctx.infra(..).request_start()returns once the start is accepted;StartInstanceInfragainswaitUntilRunning(default on). Docs and Tangle teach start, then reply 202.Checked locally: everything CI runs (nextest, doc tests, clippy, parse-only, examples, all db tests, JS checks, docs, terraform validate) and e2e instances + infra stop/cancel.