Fix assertion parsing typed refs in GC struct/array fields (#2750) - #2809
Open
ANAMASGARD wants to merge 1 commit into
Open
Fix assertion parsing typed refs in GC struct/array fields (#2750)#2809ANAMASGARD wants to merge 1 commit into
ANAMASGARD wants to merge 1 commit into
Conversation
…ly#2750) Resolve indexed GC struct/array field types via var.to_type() for numeric refs and defer VarToType for named refs until field storage is stable. Fixes the assertion on (ref N) and preserves the referenced type index. Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2750
Summary
WastParser::ParseFieldto preserve typed reference indices in GC struct/array fieldsVarToTypefor named refs until struct field storage is stable (avoids dangling pointers inresolve_ref_types_)regress-2750.txtwith non-zero index(ref 1)coverage--enable-gctorun-roundtrip.pyfor GC roundtrip testsTest plan
(ref 0))(ref 1)(ref $t1)via func typetest/run-tests.py regress-2750