Fix float argument types in wasm-interp --run-export - #2811
Merged
Conversation
sbc100
approved these changes
Aug 8, 2026
sbc100
left a comment
sbc100
left a comment
Member
There was a problem hiding this comment.
Wow, I'm surprised we didn't have any coverage for this already.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2664.
ParseFloatandParseDoublereturn the IEEE-754 bit pattern in an unsigned integer.ParseWasmValuepassed those integers directly toValue::Set, so debug builds taggedf32/f64command-line arguments asi32/i64. The interpreter then failed its value-stack type check as soon as the exported function consumed an argument.Bitcast the parsed bits to the corresponding floating-point type before storing them. This preserves both the value and the interpreter type tag.
A CLI regression test covers both
f32andf64arguments.Validation:
python3 test/run-tests.py interp/run-export-with-float-arguments --bindir=build -vpython3 test/run-tests.py interp --bindir=build -j4./build/wabt-unittests(135 tests passed)