wasm2c: reject contradictory imports instead of aborting - #2813
Open
ANAMASGARD wants to merge 1 commit into
Open
wasm2c: reject contradictory imports instead of aborting#2813ANAMASGARD wants to merge 1 commit into
ANAMASGARD wants to merge 1 commit into
Conversation
Preflight ComputeUniqueImports() before codegen and return Result::Error when the same module/field name is imported with different external kinds, instead of hitting UNIMPLEMENTED/abort on valid-but-unlinkable modules. Fixes WebAssembly#2751 Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
sbc100
approved these changes
Aug 8, 2026
Member
|
Seems reasonable to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2751
Summary
UNIMPLEMENTED("contradictory import declaration")with a stderr diagnostic andResult::ErrorComputeUniqueImports()at the start ofWriteModule()so codegen never runs on unlinkable modulestest/wasm2c/contradictory-imports.txtTest plan
wasm2c dup.wasmexits 1 with error message (no abort)python3 test/run-tests.py test/wasm2c/contradictory-imports.txtpython3 test/run-tests.py test/wasm2c/./out/wabt-unittests