Skip to content

fixed partial update put false positive for write-only fields #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcuri82 merged 1 commit into from
Sep 30, 2026
Merged

fixed partial update put false positive for write-only fields #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...2etests/spring/openapi/v3/httporaclefp/partialupdateputfp/HttpPartialUpdatePutFPEMTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import org.evomaster.e2etests.spring.openapi.v3.SpringTestBase
import org.junit.jupiter.api.Assertions.assertFalse
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.BeforeAll
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test

class HttpPartialUpdatePutFPEMTest : SpringTestBase(){
Expand All @@ -21,8 +20,6 @@ class HttpPartialUpdatePutFPEMTest : SpringTestBase(){
}
}

//FIXME: fails due to missing "hidden" not ignored as not defined in schema of GET
@Disabled("Currently failing, as revealing a bug in the code")
@Test
fun testRunEM() {

Expand Down
19 changes: 10 additions & 9 deletions core/src/main/kotlin/org/evomaster/core/problem/rest/oracle/HttpSemanticsOracle.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,13 @@ object HttpSemanticsOracle {
return null
}

val wipedFields = computeWipedFields(allPutSchemaFields - sentFields, schema, get)
val getSchemaFields = extractGetSchemaFields(schema, get)
val comparableSentFields = if (getSchemaFields.isEmpty()) sentFields else sentFields intersect getSchemaFields
val wipedFields = if (getSchemaFields.isEmpty()) emptySet() else (allPutSchemaFields - sentFields) intersect getSchemaFields

val mismatches = mismatchedPutFields(putBody ?: "", getBody, sentFields, wipedFields, bodyParam)
if (comparableSentFields.isEmpty() && wipedFields.isEmpty()) return null

val mismatches = mismatchedPutFields(putBody ?: "", getBody, comparableSentFields, wipedFields, bodyParam)
if(mismatches.isEmpty()){
return null
}
Expand Down Expand Up @@ -391,21 +395,18 @@ object HttpSemanticsOracle {
}

/**
* Wiped candidates are restricted to fields the GET schema actually exposes, otherwise
* Sent and wiped candidates are restricted to fields the GET schema actually exposes, otherwise
* write-only fields (e.g. passwords) would cause false positives.
*/
private fun computeWipedFields(
candidates: Set<String>,
private fun extractGetSchemaFields(
schema: RestSchema?,
get: RestCallAction
): Set<String> {
if (candidates.isEmpty() || schema == null) return emptySet()
val getSchemaFields = SchemaUtils.extractResponseSchemaFields(
if (schema == null) return emptySet()
return SchemaUtils.extractResponseSchemaFields(
schema, get.path.toString(), HttpVerb.GET,
statusMatcher = SchemaUtils.statusGroupMatcher(StatusGroup.G_2xx)
)
if (getSchemaFields.isEmpty()) return emptySet()
return candidates intersect getSchemaFields
}

internal fun mismatchedPutFields(
Expand Down
45 changes: 45 additions & 0 deletions core/src/test/kotlin/org/evomaster/core/problem/rest/oracle/HttpSemanticsOracleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,51 @@ class HttpSemanticsOracleTest {
assertFalse(mismatch)
}

@Test
fun testPut_sentWriteOnlyFieldNotInGetSchema_noFalsePositive() {
val schema = buildUsersSchema(
putWritable = listOf("name", "hidden"),
getResponseFields = listOf("name", "timestamp")
)
val mismatch = runMismatchedPutOracle(
path = "/users",
putBody = jsonPutBodyParam(activeFields = mapOf("name" to "Alice", "hidden" to "secret")),
getResponseBody = """{"name":"Alice","timestamp":"123"}""",
schema = schema
)
assertFalse(mismatch)
}

@Test
fun testPut_sentWriteOnlyFieldNotInGetSchema_exposedFieldChanged_returnsTrue() {
val schema = buildUsersSchema(
putWritable = listOf("name", "hidden"),
getResponseFields = listOf("name")
)
val mismatch = runMismatchedPutOracle(
path = "/users",
putBody = jsonPutBodyParam(activeFields = mapOf("name" to "Alice", "hidden" to "secret")),
getResponseBody = """{"name":"Bob"}""",
schema = schema
)
assertTrue(mismatch)
}

@Test
fun testPut_allSentFieldsWriteOnly_returnsFalse() {
val schema = buildUsersSchema(
putWritable = listOf("hidden"),
getResponseFields = listOf("id")
)
val mismatch = runMismatchedPutOracle(
path = "/users",
putBody = jsonPutBodyParam(activeFields = mapOf("hidden" to "secret")),
getResponseBody = """{"id":"1"}""",
schema = schema
)
assertFalse(mismatch)
}

@Test
fun testPut_putReturnedNon2xx_returnsFalse() {
val mismatch = runMismatchedPutOracle(
Expand Down
Loading