complete Neo4j insertions with the properties of the entity classes - #1811
Draft
andyfelder16 wants to merge 1 commit into
Draft
andyfelder16 wants to merge 1 commit into
andyfelder16 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #1793 an inserted node only carries the properties the failed query compares, so the code after the match runs on missing values. Neo4j has no schema to read them from, but SUTs using Spring Data declare them in their
@Nodeclasses.Neo4jEntityAnalyzerin the instrumentation reads the@Nodeclasses of the SUT by annotation nameNeo4jEntityDto,Neo4jEntityPropertyDtoandNeo4jEntityRelationshipDtotravel inUnitsInfoDto.neo4jEntitiesNeo4jSchemain the core, held byEnterpriseSamplerand initialized with the SQL schemaNeo4jInsertBuilderadds to each node the properties its entity declares and the query did not fix, as free genes bounded by the Java type or restricted to the enum constants; the insertion key still uses the query properties onlyentity/findbynameinspring-rest-neo4j, with a@Node Personwhose insertion carries every property