fix: Add Warning Messages About Invalid License Key and Usage Exceed - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
lang/en/local_wproofreader.php: addedusage_limit_exceededandservice_id_invalidstrings.classes/local/config_builder.php: passusageLimitExceededMessageandserviceIdInvalidMessagethrough to the JS config.amd/src/settings_page.js: on a 403 from the service, show the usage-limit message when the error mentions quota, otherwise show the invalid-license message.classes/local/settings_page_heading.php(new):admin_setting_headingsubclass whoseoutput_html()queues the settings-page AMD module only when the WProofreader settings page is the one being rendered.settings.php: gate the setting definitions behind$ADMIN->fulltree(matches the pattern used by Moodle core plugins, e.g.blocks/rss_client) and use the new heading class to trigger the language-list check.amd/build/settings_page.min.jsand.map: rebuilt via Moodle's grunt task.Testing
Manual testing on Moodle 4.5 & 5.2 setups.

