This repository was archived by the owner on Aug 27, 2026. It is now read-only.
Implement missing ICoreModule methods - #7
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a
FatalErrorExceptionoccurring becauseMiraheze\CreateWiki\Helpers\ManageWikiCoreModuledid not implement three abstract methods required by theMiraheze\ManageWiki\ICoreModuleinterface.The
ICoreModuleinterface inWikiOasis/ManageWikiwas updated to includegetDeploymentGroup(),setDeploymentGroup(), andgetDeploymentGroupOptions(). However,ManageWikiCoreModuleinWikiOasis/CreateWikiwas not updated concurrently, leading to a runtime error when the class was instantiated.This fix adds stub implementations for these three methods to
ManageWikiCoreModule:getDeploymentGroup()now returns an empty string''.setDeploymentGroup()is implemented as a no-op.getDeploymentGroupOptions()now returns an empty array[].These stub implementations satisfy the interface contract without introducing new functionality, as the
CreateWikiextension'sRemoteWikicontext does not directly utilize these deployment group concepts.Fixes MEDIAWIKI-2B9
This PR was automatically generated by Sentry. You can adjust this setting at any time.