Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Implement missing ICoreModule methods - #7

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/missing-icoremodule-methods-J0LWvP
Open

Implement missing ICoreModule methods#7
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/missing-icoremodule-methods-J0LWvP

Conversation

@sentry

@sentry sentry Bot commented Aug 24, 2026

Copy link
Copy Markdown

This PR resolves a FatalErrorException occurring because Miraheze\CreateWiki\Helpers\ManageWikiCoreModule did not implement three abstract methods required by the Miraheze\ManageWiki\ICoreModule interface.

The ICoreModule interface in WikiOasis/ManageWiki was updated to include getDeploymentGroup(), setDeploymentGroup(), and getDeploymentGroupOptions(). However, ManageWikiCoreModule in WikiOasis/CreateWiki was not updated concurrently, leading to a runtime error when the class was instantiated.

This fix adds stub implementations for these three methods to ManageWikiCoreModule:

  • getDeploymentGroup() now returns an empty string ''.
  • setDeploymentGroup() is implemented as a no-op.
  • getDeploymentGroupOptions() now returns an empty array [].

These stub implementations satisfy the interface contract without introducing new functionality, as the CreateWiki extension's RemoteWiki context does not directly utilize these deployment group concepts.

Fixes MEDIAWIKI-2B9

This PR was automatically generated by Sentry. You can adjust this setting at any time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants