refactor!: drop bootstrap-cache hooks from client#67
Draft
mickvandijke wants to merge 2 commits intomainfrom
Draft
refactor!: drop bootstrap-cache hooks from client#67mickvandijke wants to merge 2 commits intomainfrom
mickvandijke wants to merge 2 commits intomainfrom
Conversation
saorsa-core removed BootstrapManager and the cached_peer_count / add_discovered_peer / update_peer_metrics methods on P2PNode. The only consumer in ant-client was peer_cache::record_peer_outcome, which fed observed RTT and success/failure into the cache from the chunk PUT/GET and quote paths. With the cache gone, none of that plumbing has anywhere to go, so it goes too. Removes peer_cache.rs entirely, drops record_peer_outcome calls plus their start = Instant::now() RTT bookkeeping from chunk.rs and quote.rs, and removes the e2e_bootstrap_cache test that validated the persistence loop. The "peer-quality scorer lives in peer_cache" note in adaptive.rs is dropped along with it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pulls in the matching ant-protocol branch which transitively pulls the saorsa-core and saorsa-transport branches with the bootstrap cache code removed. Required for this ant-client branch to build. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ant-core/src/data/client/peer_cache.rs(therecord_peer_outcomehelper that fed observed RTT and success/failure into the now-removed BootstrapManager).record_peer_outcomecalls and the surroundingstart = Instant::now()RTT bookkeeping fromchunk.rsandquote.rs.tests/e2e_bootstrap_cache.rs(validated the persistence loop; no value with the manager gone).adaptive.rs.ant-protocolto track the corresponding branch.Depends on
Test plan
cargo check --workspacecargo clippy --workspace -- -D warningscargo test --lib(223 passed locally)ant-node = \"0.11.0\"brings registry saorsa-core; path ant-protocol brings the branch saorsa-core) is not addressed here. A[patch.crates-io]follow-up will fix it.🤖 Generated with Claude Code