Repository navigation
Add the translation download to the release steps - #547
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ryanwelcher
added this pull request to stack #545
September 29, 2026 14:15
zaerl
self-requested a review
September 30, 2026 07:31
ryanwelcher
removed this pull request from stack #545
September 30, 2026 16:10
The version-bump pull request now runs npm run i18n:download and commits src/languages/, and CONTRIBUTING.md's Back: bullet links to that step. The sentence about translate.wordpress.org not having the project yet goes from CONTRIBUTING.md: it does now.
ryanwelcher
force-pushed
the
add/releasing-doc-translations
branch
from
October 7, 2026 17:48
9317692 to
a732d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every release now needs
npm run i18n:downloadin the version-bump PR. Skip it and the build ships old translations or none, and nothing fails. #546 documented the release without this step. translate.wordpress.org now has the project, and Polish is at 100%, so the next release will ship a catalog.What changes
RELEASING.mdstep 1 gains the download as sub-step 4: run it, commitsrc/languages/, and paste the coverage table into the bump PR. It says what is held back (right-to-left locales), what it prints when nothing qualifies, that it removes every other catalog insrc/languages/, and that a failed run changes nothing.src/languages/".RELEASING.mdstep 3 says the Windows artifact may download with adist_prefix, which has to be removed before it is attached to the release.CONTRIBUTING.md's "Back:" bullet links to the step, and loses the sentence saying translate.wordpress.org doesn't have the project yet.Not here: the CI check #543 suggests, which would fail a bump PR whose
src/languages/doesn't match translate.wordpress.org.How to test this
Platforms: any. Run from the repository root on this branch.
RELEASING.mdstep 1. Each claim in sub-step 4 matchesscripts/download-translations.cjs.npm run i18n:download. It writessrc/languages/pl.jsonand prints a coverage table listingpl. Clean up withgit checkout -- src/languages && git clean -f src/languages.CONTRIBUTING.md#translatable-stringslink inRELEASING.mdand theRELEASING.mdlink inCONTRIBUTING.md's "Back:" bullet. Both land on the right heading.What must not have happened: no file outside
RELEASING.mdandCONTRIBUTING.mdchanges. Step 2's download removes any untracked catalog insrc/languages/, so move one aside first if you want to keep it.Risks and limitations
Related
Fixes #543 together with #546.
Review outcome (required — see AGENTS.md)
24086a8against trunk6d5f334.No locales downloaded.prints when no locale is over 80%. It prints only when nothing ships, nothing is held back and nothing is removed.Not shipped:, and only when they reach 80%.src/languages/, untracked ones included.src/languages/unchanged.#translatable-strings, and step 1's sub-steps now run to 6, which overlaps the section numbers. Nothing refers to them by number.24086a8 → 7ebde3f: the four fixes above in step 1, and thedist_note in step 3. Not re-reviewed; both are docs only.🤖 Generated with Claude Code