Skip to content

Add the translation download to the release steps - #547

Merged
ryanwelcher merged 2 commits into
trunkfrom
add/releasing-doc-translations
Oct 8, 2026
Merged

ryanwelcher merged 2 commits into
trunkfrom
add/releasing-doc-translations

Conversation

@ryanwelcher

@ryanwelcher ryanwelcher commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Every release now needs npm run i18n:download in the version-bump PR. Skip it and the build ships old translations or none, and nothing fails. #546 documented the release without this step. translate.wordpress.org now has the project, and Polish is at 100%, so the next release will ship a catalog.

What changes

  • RELEASING.md step 1 gains the download as sub-step 4: run it, commit src/languages/, and paste the coverage table into the bump PR. It says what is held back (right-to-left locales), what it prints when nothing qualifies, that it removes every other catalog in src/languages/, and that a failed run changes nothing.
  • The "exactly three changed lines" check now reads "outside src/languages/".
  • RELEASING.md step 3 says the Windows artifact may download with a dist_ prefix, which has to be removed before it is attached to the release.
  • CONTRIBUTING.md's "Back:" bullet links to the step, and loses the sentence saying translate.wordpress.org doesn't have the project yet.

Not here: the CI check #543 suggests, which would fail a bump PR whose src/languages/ doesn't match translate.wordpress.org.

How to test this

Platforms: any. Run from the repository root on this branch.

  1. Read RELEASING.md step 1. Each claim in sub-step 4 matches scripts/download-translations.cjs.
  2. Run npm run i18n:download. It writes src/languages/pl.json and prints a coverage table listing pl. Clean up with git checkout -- src/languages && git clean -f src/languages.
  3. Click the CONTRIBUTING.md#translatable-strings link in RELEASING.md and the RELEASING.md link in CONTRIBUTING.md's "Back:" bullet. Both land on the right heading.

What must not have happened: no file outside RELEASING.md and CONTRIBUTING.md changes. Step 2's download removes any untracked catalog in src/languages/, so move one aside first if you want to keep it.

Risks and limitations

Related

Fixes #543 together with #546.


Review outcome (required — see AGENTS.md)
  • Review: completed. Fresh-context Explore agent on 24086a8 against trunk 6d5f334.
    • Medium, fixed: the step said No locales downloaded. prints when no locale is over 80%. It prints only when nothing ships, nothing is held back and nothing is removed.
    • Low, fixed: right-to-left locales are listed after the table under the plain-text Not shipped:, and only when they reach 80%.
    • Low, fixed: the download removes every other catalog in src/languages/, untracked ones included.
    • Low, fixed: a failed run leaves src/languages/ unchanged.
    • Nits, left: the link could point at the subsection instead of #translatable-strings, and step 1's sub-steps now run to 6, which overlaps the section numbers. Nothing refers to them by number.
  • Since review: 24086a8 → 7ebde3f: the four fixes above in step 1, and the dist_ note in step 3. Not re-reviewed; both are docs only.
  • CodeRabbit: not requested.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: WordPress/contributor-toolkit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f1327d6-f24a-4900-b718-56562561bbae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryanwelcher
ryanwelcher added this pull request to stack #545 September 29, 2026 14:15
@zaerl
zaerl self-requested a review September 30, 2026 07:31
@ryanwelcher
ryanwelcher removed this pull request from stack #545 September 30, 2026 16:10
Base automatically changed from add/i18n-translate-wporg to trunk October 1, 2026 15:43
@ryanwelcher ryanwelcher modified the milestones: v1.2.2, v2.0.0 Oct 1, 2026
The version-bump pull request now runs npm run i18n:download and commits
src/languages/, and CONTRIBUTING.md's Back: bullet links to that step. The
sentence about translate.wordpress.org not having the project yet goes from
CONTRIBUTING.md: it does now.
@ryanwelcher
ryanwelcher force-pushed the add/releasing-doc-translations branch from 9317692 to a732d75 Compare October 7, 2026 17:48
@ryanwelcher ryanwelcher added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 8, 2026
@ryanwelcher ryanwelcher self-assigned this Oct 8, 2026
@ryanwelcher
ryanwelcher merged commit 82a9e6b into trunk Oct 8, 2026
8 checks passed
@ryanwelcher
ryanwelcher deleted the add/releasing-doc-translations branch October 8, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the release process

1 participant