Skip to content

Fix FOUND_ROWS() without SQL_CALC_FOUND_ROWS #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanJakes merged 2 commits into from
Oct 14, 2026
Merged

Fix FOUND_ROWS() without SQL_CALC_FOUND_ROWS #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf51a68
Fix FOUND_ROWS() for more than nine rows without SQL_CALC_FOUND_ROWS
Nandan108 Oct 12, 2026
3bed95e
Test FOUND_ROWS() with two-digit counts and without stringified fetches
JanJakes Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mysql-on-sqlite/src/sqlite/class-wp-mysql-on-sqlite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5169,12 +5169,12 @@ private function translate_function_call( WP_Parser_Node $node ): string {
} elseif ( is_string( $found_rows ) ) {
return (int) $this->execute_sqlite_query(
sprintf( 'SELECT COUNT(*) FROM (%s)', $found_rows )
)->fetchColumn()[0];
)->fetchColumn();
} elseif ( is_array( $found_rows ) && isset( $found_rows[0] ) ) {
return (int) $this->execute_sqlite_query(
sprintf( 'SELECT COUNT(*) FROM (%s)', $found_rows[0] ),
$found_rows[1] ?? array()
)->fetchColumn()[0];
)->fetchColumn();
} else {
return 0;
}
Expand Down
42 changes: 25 additions & 17 deletions packages/mysql-on-sqlite/tests/WP_MySQL_On_SQLite_Tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4186,79 +4186,87 @@ public function testCalcFoundRows() {
);
}

public function testFoundRowsWithoutSqlCalcFoundRows(): void {
/**
* @dataProvider stringifyFetchesProvider
*/
public function testFoundRowsWithoutSqlCalcFoundRows( bool $stringify_fetches ): void {
$this->engine->setAttribute( PDO::ATTR_STRINGIFY_FETCHES, $stringify_fetches );

$this->assertQuery( 'DROP TABLE _dates' );
$this->assertQuery( 'DROP TABLE _options' );

// CREATE TABLE
$this->assertQuery( 'CREATE TABLE t (id INT PRIMARY KEY, value TEXT, INDEX idx_value (value))' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '0', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 0, $result[0]->{'FOUND_ROWS()'} );

// INSERT
$this->assertQuery( 'INSERT INTO t (id) VALUES (1), (2), (3)' );
$this->assertQuery( 'INSERT INTO t (id) VALUES (1), (2), (3), (4), (5), (6), (7), (8), (9), (10), (11), (12)' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '0', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 0, $result[0]->{'FOUND_ROWS()'} );

// SELECT
$this->assertQuery( 'SELECT * FROM t' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '3', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 12, $result[0]->{'FOUND_ROWS()'} );

// DESCRIBE
$this->assertQuery( 'DESCRIBE t' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '2', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 2, $result[0]->{'FOUND_ROWS()'} );

// SHOW COLLATION
$this->assertQuery( 'SHOW COLLATION' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '8', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 8, $result[0]->{'FOUND_ROWS()'} );

// SHOW DATABASES
$this->assertQuery( 'SHOW DATABASES' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '2', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 2, $result[0]->{'FOUND_ROWS()'} );

// SHOW COLUMNS
$this->assertQuery( 'SHOW COLUMNS FROM t' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '2', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 2, $result[0]->{'FOUND_ROWS()'} );

// SHOW CREATE TABLE
$this->assertQuery( 'SHOW CREATE TABLE t' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '1', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 1, $result[0]->{'FOUND_ROWS()'} );

// SHOW CREATE TABLE with non-existent table
$this->assertQuery( 'SHOW CREATE TABLE non_existent_table' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '0', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 0, $result[0]->{'FOUND_ROWS()'} );

// SHOW INDEX
$this->assertQuery( 'SHOW INDEX FROM t' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '2', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 2, $result[0]->{'FOUND_ROWS()'} );

// SHOW GRANTS
$this->assertQuery( 'SHOW GRANTS' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '1', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 1, $result[0]->{'FOUND_ROWS()'} );

// SHOW TABLE STATUS
$r = $this->assertQuery( 'SHOW TABLE STATUS' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '1', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 1, $result[0]->{'FOUND_ROWS()'} );

// SHOW TABLES
// SHOW TABLES (with a two-digit count)
for ( $i = 1; $i <= 10; $i++ ) {
$this->assertQuery( "CREATE TABLE t$i (id INT)" );
}
$this->assertQuery( 'SHOW TABLES' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '1', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 11, $result[0]->{'FOUND_ROWS()'} );

// SHOW VARIABLES
$this->assertQuery( 'SHOW VARIABLES' );
$result = $this->assertQuery( 'SELECT FOUND_ROWS()' );
$this->assertSame( '2', $result[0]->{'FOUND_ROWS()'} );
$this->assertEquals( 2, $result[0]->{'FOUND_ROWS()'} );
}

public function testComplexSelectBasedOnDates() {
Expand Down
Loading