64952 quick draft prevent empty draft by afercia · Pull Request #12194 · WordPress/wordpress-develop

afercia · 2026-06-16T22:08:26Z

Trac ticket: https://core.trac.wordpress.org/ticket/64952

Use of AI Tools

Example disclosure:

AI assistance: Yes
Tool(s): GitHub Copilot
Model(s): Claude HAIKU 4.5
Used for: Initial research of the change that introduced the regrsssion.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2026-06-16T22:08:35Z

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

github-actions · 2026-06-16T22:08:43Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props afercia, joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-06-16T22:12:30Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

afercia · 2026-06-19T12:36:29Z

+
+		// Wrap Quick Draft content in a Paragraph block.
+		if (
+			use_block_editor_for_post_type( 'post' ) &&


Question: is Quick Draft used only for 'post' post types?

I was unable to find any evidence it's usable by any other post type.

joedolson

This is mostly looking pretty good; there are a few polishing elements I think would help.

joedolson · 2026-06-23T22:05:27Z

 				// Focus the title to allow for quickly drafting another post.
-				$('#title').trigger( 'focus' );
-			});
+				$( '#title' ).focus();


The .focus() shorthand was deprecated; is there a reason you're making this change? https://api.jquery.com/focus-shorthand/

I will revert it

joedolson · 2026-06-23T22:09:08Z

+ * @param string       $notice_type Optional. Admin notice type. Default 'notice-error'.
 */
-function wp_dashboard_quick_press( $error_msg = false ) {
+function wp_dashboard_quick_press( $message = false, $notice_type = 'notice-error' ) {


wp_admin_notice() takes an array argument that has a type parameter, accepting just 'error', 'success', 'warning', etc. I think that $notice_type should just pass the value used by the type param in that function.

joedolson · 2026-06-23T22:09:50Z

+				$message,
 				array(
-					'additional_classes' => array( 'error' ),
+					'additional_classes' => array( $notice_type ),


Instead of adding this as an additional class, pass the type param with a simple type from $notice_type, as suggested above.

joedolson · 2026-06-23T22:18:30Z

-		// Wrap Quick Draft content in the Paragraph block.
-		if ( ! str_contains( $_POST['content'], '<!-- wp:paragraph -->' ) ) {
+		$quickdraft_post_title   = trim( $_POST['post_title'] );
+		$quickdraft_post_content = trim( $_POST['content'] );


This wasn't sanitized in the original, but it seems like it would be better to sanitize these variables here.

I think the sanitization is in the chain of calls: edit_post(), wp_update_post(), and ultimately wp_insert_post(), which calls sanitize_post().

joedolson · 2026-06-23T22:21:10Z

-				$('#quick-press').removeClass('initial-form');
+				$( '#dashboard_quick_press .inside' ).html( data );
 				quickPressLoad();
 				highlightLatestPost();


highlightLatestPost() shouldn't fire if the quick draft throws an error; will need to add a check for an error message as a condition in that.

afercia · 2026-07-01T14:31:36Z

Addressed CR feedback. Should be good to go now.

…r is in use.

github-actions · 2026-07-08T19:17:19Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62670
GitHub commit: 585ec6c

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

afercia requested a review from SergeyBiryukov June 19, 2026 12:34

afercia commented Jun 19, 2026

View reviewed changes

afercia force-pushed the 64952-quick-draft-prevent-empty-draft branch from b790734 to 7e947a8 Compare June 21, 2026 13:21

joedolson requested changes Jun 23, 2026

View reviewed changes

afercia force-pushed the 64952-quick-draft-prevent-empty-draft branch from 7e947a8 to 931067b Compare July 1, 2026 13:57

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:10

afercia force-pushed the 64952-quick-draft-prevent-empty-draft branch from 2e02089 to 00f3566 Compare July 7, 2026 13:45

afercia added 12 commits July 8, 2026 18:03

Prevent creation of empty draft from Quick Draft dashboard widget.

6e7fbd6

Only wrap Quick Draft content in a Paragraph block if the block edito…

72adcb2

…r is in use.

Make Quick Draft notice an ARIA alert.

1704914

Add E2E tests for the Quick Draft.

5bce307

Pass post type.

ad7f722

Add success notice.

e9b4a5b

Clean up Quick Press JavaScript.

bc4cf09

Clean up Quick Press css.

5021ada

Use the type parameter for the admin notice instead of additional class.

84556a4

Do not highlight recent drafts first item when there is an error.

cbb277d

Revert trigger focus.

54a0928

Improve test description.

8db8ed1

afercia force-pushed the 64952-quick-draft-prevent-empty-draft branch from 00f3566 to 8db8ed1 Compare July 8, 2026 16:03

github-actions Bot closed this Jul 8, 2026

Uh oh!

Conversation

afercia commented Jun 16, 2026

Use of AI Tools

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

github-actions Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 16, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joedolson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afercia commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 16, 2026 •

edited

Loading