Skip to content

Enhance classic editor timestamp fields with native controls #12275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poligilad-auto wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Enhance classic editor timestamp fields with native controls #12275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 87 additions & 7 deletions src/js/_enqueues/admin/post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,13 +303,15 @@ window.wp = window.wp || {};
*/
jQuery( function($) {
var stamp, visibility, $submitButtons, updateVisibility, updateText,
updateFieldsFromNativeTimestamp, setupNativeTimestampFields, updateNativeTimestampFields,
$textarea = $('#content'),
$document = $(document),
postId = $('#post_ID').val() || 0,
$submitpost = $('#submitpost'),
releaseLock = true,
$postVisibilitySelect = $('#post-visibility-select'),
$timestampdiv = $('#timestampdiv'),
$timestampEdit = $timestampdiv.closest( '.misc-pub-curtime' ).find( 'a.edit-timestamp' ),
$postStatusSelect = $('#post-status-select'),
isMac = window.navigator.platform ? window.navigator.platform.indexOf( 'Mac' ) !== -1 : false,
copyAttachmentURLClipboard = new ClipboardJS( '.copy-attachment-url.edit-media' ),
Expand Down Expand Up @@ -784,10 +786,10 @@ jQuery( function($) {
attemptedDate.getDate() != jj ||
attemptedDate.getMinutes() != mn
) {
$timestampdiv.find('.timestamp-wrap').addClass('form-invalid');
$timestampdiv.find( '.timestamp-wrap, #publish-date-native' ).addClass( 'form-invalid' );
return false;
} else {
$timestampdiv.find('.timestamp-wrap').removeClass('form-invalid');
$timestampdiv.find( '.timestamp-wrap, .timestamp-native-wrap input' ).removeClass( 'form-invalid' );
Comment on lines +789 to +792

@tyxla tyxla Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make these selectors consistent?

}

// Determine what the publish should be depending on the date and post status.
Expand Down Expand Up @@ -866,6 +868,79 @@ jQuery( function($) {
return true;
};

updateFieldsFromNativeTimestamp = updateText;
updateNativeTimestampFields = function() {};

setupNativeTimestampFields = function() {
var dateInput = document.createElement( 'input' ),
timeInput = document.createElement( 'input' ),
$timestampwrap = $timestampdiv.find( '.timestamp-wrap' ),
$nativeTimestampWrap = $timestampdiv.find( '.timestamp-native-wrap' ),
$dateInput, $timeInput,
toDateValue, toTimeValue;

dateInput.setAttribute( 'type', 'date' );
timeInput.setAttribute( 'type', 'time' );
if (
'date' !== dateInput.type ||
'time' !== timeInput.type ||
! $timestampwrap.length ||
! $nativeTimestampWrap.length
) {
return;
}

toDateValue = function() {
return $( '#aa' ).val() + '-' +
( '00' + $( '#mm' ).val() ).slice( -2 ) + '-' +
( '00' + $( '#jj' ).val() ).slice( -2 );
};

toTimeValue = function() {
return ( '00' + $( '#hh' ).val() ).slice( -2 ) + ':' +
( '00' + $( '#mn' ).val() ).slice( -2 );
};

$dateInput = $nativeTimestampWrap.find( '#publish-date-native' );
$timeInput = $nativeTimestampWrap.find( '#publish-time-native' );

updateFieldsFromNativeTimestamp = function() {
var dateMatches = $dateInput.val().match( /^(\d{4})-(\d{2})-(\d{2})$/ ),
timeMatches = $timeInput.val().match( /^(\d{2}):(\d{2})$/ );

$dateInput.toggleClass( 'form-invalid', ! dateMatches );
$timeInput.toggleClass( 'form-invalid', ! timeMatches );

if ( ! dateMatches || ! timeMatches ) {
$timestampwrap.addClass( 'form-invalid' );
return false;
}

$( '#aa' ).val( dateMatches[1] );
$( '#mm' ).val( dateMatches[2] );
$( '#jj' ).val( dateMatches[3] );
$( '#hh' ).val( timeMatches[1] );
$( '#mn' ).val( timeMatches[2] );

// Seconds remain in the existing hidden field, matching the legacy timestamp UI.
return updateText();
};

updateNativeTimestampFields = function() {
$dateInput.val( toDateValue() );
$timeInput.val( toTimeValue() );
};

updateNativeTimestampFields();
$timestampdiv.addClass( 'has-native-timestamp-fields' );
$timestampwrap.hide();
$nativeTimestampWrap.removeAttr( 'hidden' );
$nativeTimestampWrap.find( 'input' ).on( 'change', updateFieldsFromNativeTimestamp );
$timestampwrap.find( 'input, select' ).on( 'change', updateNativeTimestampFields );
};

setupNativeTimestampFields();

// Show the visibility options and hide the toggle button when opened.
$( '#visibility .edit-visibility').on( 'click', function( e ) {
e.preventDefault();
Expand Down Expand Up @@ -924,10 +999,13 @@ jQuery( function($) {
});

// Edit publish time click.
$timestampdiv.siblings('a.edit-timestamp').on( 'click', function( event ) {
$timestampEdit.on( 'click', function( event ) {
if ( $timestampdiv.is( ':hidden' ) ) {
$timestampdiv.slideDown( 'fast', function() {
$( 'input, select', $timestampdiv.find( '.timestamp-wrap' ) ).first().trigger( 'focus' );
$timestampdiv.find( '.timestamp-native-wrap input, .timestamp-wrap input, .timestamp-wrap select' )
.filter( ':visible' )
.first()
.trigger( 'focus' );
} );
$(this).hide();
}
Expand All @@ -936,21 +1014,23 @@ jQuery( function($) {

// Cancel editing the publish time and hide the settings.
$timestampdiv.find('.cancel-timestamp').on( 'click', function( event ) {
$timestampdiv.slideUp('fast').siblings('a.edit-timestamp').show().trigger( 'focus' );
$timestampdiv.slideUp('fast');
$timestampEdit.show().trigger( 'focus' );
$('#mm').val($('#hidden_mm').val());
$('#jj').val($('#hidden_jj').val());
$('#aa').val($('#hidden_aa').val());
$('#hh').val($('#hidden_hh').val());
$('#mn').val($('#hidden_mn').val());
updateNativeTimestampFields();
updateText();
event.preventDefault();
});

// Save the changed timestamp.
$timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels.
if ( updateText() ) {
if ( updateFieldsFromNativeTimestamp() ) {
$timestampdiv.slideUp('fast');
$timestampdiv.siblings('a.edit-timestamp').show().trigger( 'focus' );
$timestampEdit.show().trigger( 'focus' );
}
event.preventDefault();
});
Expand Down
79 changes: 79 additions & 0 deletions src/wp-admin/css/edit.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,46 @@ form#tags-filter {
height: auto !important;
}

.misc-pub-curtime {
display: grid;
grid-template-columns: 27px minmax( 0, 1fr );
}

.misc-pub-curtime .timestamp-display {
grid-column: 2;
min-width: 0;
}

.misc-pub-curtime:before {
content: "\f145";
content: "\f145" / '';
font: normal 20px/1 dashicons;
grid-column: 1;
grid-row: 1;
margin-left: -1px;
padding-right: 3px;
position: relative;
top: -1px;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}

.misc-pub-curtime #timestamp:before {
content: none;
}

.misc-pub-curtime .edit-timestamp {
margin-left: 0;
}

.misc-pub-curtime .edit-timestamp-label {
white-space: nowrap;
}

.misc-pub-curtime #timestampdiv {
grid-column: 1 / -1;
}

#post-body .misc-pub-post-status:before,
#post-body #visibility:before,
.curtime #timestamp:before,
Expand Down Expand Up @@ -525,6 +565,10 @@ form#tags-filter {
top: -1px;
}

.misc-pub-curtime #timestamp:before {
content: none;
}
Comment on lines +568 to +570

@tyxla tyxla Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated


#post-body .misc-pub-uploadedby:before {
content: "\f110";
content: "\f110" / '';
Expand Down Expand Up @@ -562,6 +606,41 @@ form#tags-filter {
text-align: center;
}

#timestampdiv.has-native-timestamp-fields {
padding-top: 0;
}

#timestampdiv .timestamp-native-wrap {
margin: 3px 0 0;
}

#timestampdiv.has-native-timestamp-fields .timestamp-native-wrap {
display: grid;
gap: 8px;
}

#timestampdiv.has-native-timestamp-fields .timestamp-actions {
margin-top: 8px;
}

#timestampdiv .timestamp-native-wrap input {
box-sizing: border-box;
text-align: left;
width: 100%;
}

#timestampdiv .timestamp-native-wrap input.form-invalid,
#timestampdiv .timestamp-native-wrap input.form-invalid:focus {
border-color: #d63638 !important;
box-shadow: 0 0 2px rgba(214, 54, 56, 0.8);
}

#timestampdiv .timestamp-site-time {
color: #646970;
font-size: 12px;
margin: -2px 0 0;
}

.notification-dialog {
position: fixed;
top: 30%;
Expand Down
24 changes: 13 additions & 11 deletions src/wp-admin/includes/meta-boxes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,18 +285,20 @@ function post_submit_meta_box( $post, $args = array() ) {
if ( $can_publish ) : // Contributors don't get to choose the date of publish.
?>
<div class="misc-pub-section curtime misc-pub-curtime">
<span id="timestamp">
<?php printf( $stamp, '<b>' . $date . '</b>' ); ?>
</span>
<a href="#edit_timestamp" class="edit-timestamp hide-if-no-js" role="button">
<span aria-hidden="true"><?php _e( 'Edit' ); ?></span>
<span class="screen-reader-text">
<?php
/* translators: Hidden accessibility text. */
_e( 'Edit date and time' );
?>
<span class="timestamp-display">

@tyxla tyxla Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that some of these markup changes might be necessary below in some of the other meta boxes. Or we need to ensure that our CSS changes affect only this one. But right now the changes may affect the other meta boxes in weird ways because some of those markup changes are missing

<span id="timestamp">
<?php printf( $stamp, '<b>' . $date . '</b>' ); ?>
</span>
</a>
<a href="#edit_timestamp" class="edit-timestamp hide-if-no-js" role="button">
<span aria-hidden="true" class="edit-timestamp-label"><?php _e( 'Edit' ); ?></span>
<span class="screen-reader-text">
<?php
/* translators: Hidden accessibility text. */
_e( 'Edit date and time' );
?>
</span>
</a>
</span>
<fieldset id="timestampdiv" class="hide-if-js">
<legend class="screen-reader-text">
<?php
Expand Down
32 changes: 30 additions & 2 deletions src/wp-admin/includes/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,12 @@ function touch_time( $edit = 1, $for_post = 1, $tab_index = 0, $multi = 0 ) {
$cur_hh = current_time( 'H' );
$cur_mn = current_time( 'i' );

$timezone = wp_timezone_string();
if ( preg_match( '/^([+-])(\d{2}):(\d{2})$/', $timezone, $timezone_matches ) ) {
$timezone = 'UTC' . $timezone_matches[1] . (int) $timezone_matches[2];
$timezone .= ( '00' === $timezone_matches[3] ) ? '' : ':' . $timezone_matches[3];
}
Comment on lines +834 to +838

@tyxla tyxla Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTC+0 might be weird - should it just be UTC?


$month = '<label><span class="screen-reader-text">' .
/* translators: Hidden accessibility text. */
__( 'Month' ) .
Expand Down Expand Up @@ -865,7 +871,29 @@ function touch_time( $edit = 1, $for_post = 1, $tab_index = 0, $multi = 0 ) {
/* translators: 1: Month, 2: Day, 3: Year, 4: Hour, 5: Minute. */
printf( __( '%1$s %2$s, %3$s at %4$s:%5$s' ), $month, $day, $year, $hour, $minute );

echo '</div><input type="hidden" id="ss" name="ss" value="' . $ss . '" />';
echo '</div>';

if ( $for_post && ! $multi ) {
?>
<div class="timestamp-native-wrap hide-if-no-js" hidden>
<label for="publish-date-native" class="screen-reader-text"><?php _e( 'Date' ); ?></label>
<input type="date" id="publish-date-native" class="form-required" value="<?php echo esc_attr( $aa . '-' . $mm . '-' . $jj ); ?>" />
<label for="publish-time-native" class="screen-reader-text"><?php _e( 'Time' ); ?></label>
<input type="time" id="publish-time-native" class="form-required" value="<?php echo esc_attr( $hh . ':' . $mn ); ?>" />
<p class="timestamp-site-time">
<?php
printf(
/* translators: %s: The site's timezone. */
__( 'Site time: %s' ),
'<span>' . esc_html( $timezone ) . '</span>'
);
?>
</p>
</div>
<?php
}

echo '<input type="hidden" id="ss" name="ss" value="' . $ss . '" />';

if ( $multi ) {
return;
Expand All @@ -890,7 +918,7 @@ function touch_time( $edit = 1, $for_post = 1, $tab_index = 0, $multi = 0 ) {
}
?>

<p>
<p class="timestamp-actions">
<a href="#edit_timestamp" class="save-timestamp hide-if-no-js button"><?php _e( 'OK' ); ?></a>
<a href="#edit_timestamp" class="cancel-timestamp hide-if-no-js button-cancel"><?php _e( 'Cancel' ); ?></a>
</p>
Expand Down
Loading