-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Editor: Improve Classic Editor status dropdown layout #12304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0b6e1b7
177b308
d896c43
669c2a6
39f2704
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -712,6 +712,17 @@ form#tags-filter { | |||||||||||||||
| margin-top: 3px; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| #post-status-select select { | ||||||||||||||||
| display: block; | ||||||||||||||||
| margin-bottom: 8px; | ||||||||||||||||
| width: 100%; | ||||||||||||||||
| } | ||||||||||||||||
|
Comment on lines
+715
to
+719
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with this change since that way the buttons don't really shift depending on the width of the selected value. This is even more relevant on languages where those strings are longer. But it seems like
Suggested change
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. I removed
Comment on lines
+715
to
+719
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adjusted. The Status OK/Cancel controls now get a scoped |
||||||||||||||||
|
|
||||||||||||||||
| #post-status-select .save-post-status, | ||||||||||||||||
| #post-status-select .cancel-post-status { | ||||||||||||||||
| vertical-align: middle; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| #linksubmitdiv .inside, /* Old Link Manager back-compat. */ | ||||||||||||||||
| #poststuff #submitdiv .inside { | ||||||||||||||||
| margin: 0; | ||||||||||||||||
|
|
@@ -1894,12 +1905,17 @@ table.links-table { | |||||||||||||||
| line-height: 280%; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| .wp-core-ui #post-status-select .save-post-status.button, | ||||||||||||||||
| .wp-core-ui .save-post-visibility, | ||||||||||||||||
| .wp-core-ui .save-timestamp { | ||||||||||||||||
| vertical-align: middle; | ||||||||||||||||
| margin-right: 15px; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| .wp-core-ui #post-status-select .save-post-status.button { | ||||||||||||||||
| margin-left: 0; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| .timestamp-wrap select#mm { | ||||||||||||||||
| display: block; | ||||||||||||||||
| width: 100%; | ||||||||||||||||
|
|
||||||||||||||||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it seems like on mobile we have a media query that adds left margin to the OK button, that seems off:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted. The existing mobile rule for
.save-post-status.buttonwas adding an asymmetric offset that made sense for the previous inline layout, but looked off once the select became full-width. Status now shares the same mobile spacing as Visibility/Timestamp for the OK action, while clearing the old left offset.