Skip to content

Improve custom fields editing flow #12348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poligilad-auto wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Improve custom fields editing flow #12348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 146 additions & 4 deletions src/js/_enqueues/admin/post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,126 @@ jQuery( function($) {

// Custom Fields postbox.
if ( $('#postcustom').length ) {
$( '#the-list' ).wpList( {
var $postCustom = $( '#postcustom' ),
$newMeta = $postCustom.find( '#newmeta' ),
$addCustomFieldButton = $postCustom.find( '#add-custom-field-button' ),
$addCustomFieldHeading = $postCustom.find( '.custom-field-add-heading' ),
$addCustomFieldSubmit = $postCustom.find( '#postcustomstuff .add-custom-field' ),
$cancelNewMetaButton = $postCustom.find( '#newmeta-cancel' ),
$customFieldsNotice = $postCustom.find( '.custom-fields-notice' ),
$customFieldsNoticeMessage,
$enterNewMetaButton = $postCustom.find( '#newmeta-button' ),
$listTable = $postCustom.find( '#list-table' ),
$metaKeyInput = $postCustom.find( '#metakeyinput' ),
$metaKeySelect = $postCustom.find( '#metakeyselect' ),
$metaValue = $postCustom.find( '#metavalue' ),
clearNewMeta,
hideNewMeta,
resetMetaKeyInput,
showCustomFieldsNotice,
showMetaKeyInput,
showNewMeta;

if ( ! $customFieldsNotice.length ) {
$customFieldsNotice = $( '<div class="custom-fields-notice notice notice-success is-dismissible hidden"><p></p><button type="button" class="notice-dismiss"><span class="screen-reader-text"></span></button></div>' );
$customFieldsNotice.find( '.screen-reader-text' ).text( __( 'Dismiss this notice.' ) );
$postCustom.find( '#postcustomstuff' ).before( $customFieldsNotice );
}

$customFieldsNoticeMessage = $customFieldsNotice.find( 'p' );

showCustomFieldsNotice = function( message ) {
if ( ! $customFieldsNotice.length ) {
return;
}

$customFieldsNoticeMessage.text( message );
$customFieldsNotice.removeClass( 'hidden' );

wp.a11y.speak( message );
};

resetMetaKeyInput = function() {
if ( $metaKeySelect.length ) {
$metaKeySelect.prop( 'selectedIndex', 0 ).removeClass( 'hidden' );
$metaKeyInput.val( '' ).addClass( 'hidden' );
$postCustom.find( '#enternew' ).removeClass( 'hidden' );
$postCustom.find( '#cancelnew' ).addClass( 'hidden' );
}
};

showMetaKeyInput = function() {
$metaKeySelect.addClass( 'hidden' );
$metaKeyInput.removeClass( 'hidden' );
$postCustom.find( '#enternew' ).addClass( 'hidden' );
$postCustom.find( '#cancelnew' ).removeClass( 'hidden' );
$metaKeyInput.trigger( 'focus' );
};

clearNewMeta = function() {
$metaValue.val( '' );
resetMetaKeyInput();

if ( ! $metaKeySelect.length ) {
$metaKeyInput.val( '' );
}
};

showNewMeta = function( shouldFocus ) {
$newMeta.addClass( 'is-visible' ).show();
$addCustomFieldHeading.addClass( 'is-visible' );
$addCustomFieldSubmit.addClass( 'is-visible' );
$addCustomFieldButton.attr( 'aria-expanded', 'true' );

if ( false !== shouldFocus ) {
( $metaKeySelect.is( ':visible' ) ? $metaKeySelect : $metaKeyInput ).trigger( 'focus' );
}
};

hideNewMeta = function( shouldFocus ) {
clearNewMeta();
$newMeta.removeClass( 'is-visible' ).hide();
$addCustomFieldHeading.removeClass( 'is-visible' );
$addCustomFieldSubmit.removeClass( 'is-visible' );
$addCustomFieldButton.attr( 'aria-expanded', 'false' );

if ( false !== shouldFocus ) {
$addCustomFieldButton.trigger( 'focus' );
}
};

$addCustomFieldButton.on( 'click', function( event ) {
event.preventDefault();
showNewMeta();
} );

$enterNewMetaButton.on( 'click', function( event ) {
event.preventDefault();

if ( $metaKeyInput.hasClass( 'hidden' ) ) {
showMetaKeyInput();
} else {
resetMetaKeyInput();
$metaKeySelect.trigger( 'focus' );
}
} );

$cancelNewMetaButton.on( 'click', function( event ) {
event.preventDefault();
hideNewMeta();
} );

$customFieldsNotice.on( 'click', '.notice-dismiss', function() {
$customFieldsNotice.addClass( 'hidden' );
} );

if ( $listTable.hasClass( 'is-empty' ) ) {
showNewMeta( false );
}

$postCustom.find( '#the-list' ).wpList( {
addColor: 'none',
delColor: 'none',
/**
* Add current post_ID to request to fetch custom fields
*
Expand All @@ -700,16 +819,39 @@ jQuery( function($) {
* @return {Object} Data modified with post_ID attached.
*/
addBefore: function( s ) {
s.data += '&post_id=' + $('#post_ID').val();
s.data += '&post_id=' + $( '#post_ID' ).val();
return s;
},
/**
* Show the listing of custom fields after fetching.
*
* @ignore
*/
addAfter: function() {
$('table#list-table').show();
addAfter: function( returnedResponse, settings ) {
var message = 'newmeta' === settings.element ? __( 'Custom field added.' ) : __( 'Custom field updated.' );

if ( true === settings.parsed || ! settings.parsed || settings.parsed.errors ) {
return;
}

$listTable.removeClass( 'is-empty' ).addClass( 'has-fields' ).show();
showCustomFieldsNotice( message );

if ( 'newmeta' === settings.element ) {
hideNewMeta();
}
},
delAfter: function( returnedResponse, settings ) {
if ( ! settings.parsed || settings.parsed.errors ) {
return;
}

$postCustom.find( '#' + settings.element ).remove();
showCustomFieldsNotice( __( 'Custom field deleted.' ) );

if ( ! $postCustom.find( '#the-list tr.is-saved' ).length ) {
$listTable.removeClass( 'has-fields' ).addClass( 'is-empty' ).hide();
}
}
});
}
Expand Down
Loading
Loading