Security: Harden taxonomy tab handler in post.js - #12643
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the hierarchical taxonomy tab handler in the post editor admin script by avoiding passing an attribute-derived string directly into jQuery’s $() constructor, reducing exposure to unintended HTML parsing or selector injection.
Changes:
- Switch tab targeting from
hreftoaria-controlsfor identifying the associated panel. - Resolve the target panel via
document.getElementById()and pass the resulting element to jQuery. - Update the “all items” comparison to match the new non-
#-prefixed identifier format.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This PR hardens the taxonomy tab click handler in wp-admin/js/post.js to avoid passing a raw href value into jQuery’s $() constructor. This mitigates the risk of unintended HTML parsing or CSS selector injection.
Trac ticket: #65572
Use of AI Tools
AI assistance: Yes
Tool(s): GitHub Copilot
Model(s): Gemini, Claude
Used for: Checking for potential edge cases, drafting the PR description, and assisting with local code review. The final implementation and testing were written and executed manually by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.