Skip to content

Build/Test Tools: Post-branching updates for trunk - #12962

Closed
joedolson wants to merge 5 commits into
WordPress:trunkfrom
joedolson:trunk
Closed

Build/Test Tools: Post-branching updates for trunk#12962
joedolson wants to merge 5 commits into
WordPress:trunkfrom
joedolson:trunk

Conversation

@joedolson

Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/65844

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, desrosj, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano

Copy link
Copy Markdown
Contributor

Hi, I just wanted to check if this PR is ready to be committed.

@desrosj

desrosj commented Aug 12, 2026

Copy link
Copy Markdown
Member

It looks like there are no changes in this PR currently. Based on the commit history, it seems that 65ab018 (r63167) was meant to resolve this. However, the changes made to the workflow files in in that commit do not appear to be the ones that were originally staged in this PR (see a8db49c), and are incorrect.

Remote references (@trunk) should only be used for numbered branches. The workflow file changes in r63167 will need to be reverted as the local reference is preferred (this allows changes to these files within PRs to be tested without needing to make unnecessary changes to the files).

@joedolson

Copy link
Copy Markdown
Contributor Author

This is not the PR that was used for the post-branching changes; that was from #12959

@desrosj

desrosj commented Aug 12, 2026

Copy link
Copy Markdown
Member

After discussing this further in Slack:

  • This is no longer needed. It was in fact superseded by Post 7.1 branching changes #12959.
  • The changes I noted above were not actually included in either PR.
  • The process followed locally was "move to the branch, run the command, switch back to trunk, finish the rest of the process, then switch back to the branch.". So this likely reverted the file removals performed by grunt post-branching, but left the results of replace:workflow-references-local-to-remote, and resulted in those changes being included in the commit to trunk.

This part of the commit can be reverted, but this PR can be closed out.

@desrosj desrosj closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants