Upgrade/Install: Restore the sync package files in the $_old_files array. - #13061
Upgrade/Install: Restore the sync package files in the $_old_files array.#13061t-hamano wants to merge 3 commits into
$_old_files array.#13061Conversation
…array. Co-Authored-By: Claude <noreply@anthropic.com>
Perhaps these two should be executed in a single commit. |
|
I've updated the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Reviewed and tested ✅. No defects found; the change looks safe to commit to the 7.1 branch. |
|
Thank you all for your reviews! I'm glad we could address this issue before the commit freeze. I plan to update the GB Hash one more time before the commit freeze, as there are still a few PRs that need to be backported to 7.1. |
wp-includes/js/dist/sync.jsandsync.min.jswere removed in 7.0.2, but came back in 7.1. This was not intentional.The two paths are currently commented out in
$_old_fileswith a "Restored in WordPress 7.1." note. This PR restores them as active entries so that upgrading to 7.1 deletes the leftover files.Order of operations
These steps must be done in this order. Otherwise
$_old_fileswill not match what is actually shipped.wp/7.1branch.7.1branch of wordpress-develop, update the pinned Gutenberg hash to the latest commit of thewp/7.1branch.sync.jsandsync.min.jsthen disappear from core, andwp.syncis no longer exposed.Trac ticket: https://core.trac.wordpress.org/ticket/65813
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Investigating when and why the files were reintroduced, and drafting this description. The change itself is a two-line edit that I reviewed and take responsibility for.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.