Upgrade/Install: Load the .maintenance file non-fatally - #13180
Upgrade/Install: Load the .maintenance file non-fatally#13180itzmekhokan wants to merge 1 commit into
.maintenance file non-fatally#13180Conversation
`wp_is_maintenance_mode()` and `WP_Automatic_Updater::has_fatal_error()` both check for `.maintenance` with `file_exists()` and then load it with `require`. An update running in a concurrent request can delete the file between the two, and with `opcache.enable_file_override=1` the cached script entry keeps `file_exists()` returning true after the deletion, so `require` fails and terminates the request. Load the file with `include` and bail when it returns false, so a file that disappears or becomes unreadable between the check and the load leaves maintenance mode off instead of ending the request. Fixes #65911.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
After a successful update, WordPress can end the request with
Uncaught Error: Failed opening required '.maintenance'fromwp-includes/load.php.wp_is_maintenance_mode()andWP_Automatic_Updater::has_fatal_error()both check for the file withfile_exists()and then load it withrequire. A concurrent request can delete it in between, and withopcache.enable_file_override=1the cached script entry keepsfile_exists()returning true after the deletion, sorequirefails fatally. Both now load the file withincludeand bail when it returns false.The
file_exists()fast path is kept deliberately: suppressed warnings are still dispatched to custom error handlers, so loading unconditionally would add two per request on every site.Trac ticket: https://core.trac.wordpress.org/ticket/65911
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Reproducing the failure shape, drafting the patch, and adding a regression test. All changes were reviewed and validated by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.