Skip to content

Tests: Reset comment globals between tests #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sirreal wants to merge 2 commits into
base: trunk
Choose a base branch
from
+7 −1
Draft

Tests: Reset comment globals between tests #13186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a87312a
Tests: Reset global comment after author URL tests
sirreal Aug 19, 2026
b9f58b1
Tests: Reset comment loop state between tests
sirreal Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/phpunit/includes/abstract-testcase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public function tear_down() {
}

// Reset comment globals.
$comment_globals = array( 'comment_alt', 'comment_depth', 'comment_thread_alt' );
$comment_globals = array( 'comment_alt', 'comment_depth', 'comment_thread_alt', 'in_comment_loop' );
foreach ( $comment_globals as $global ) {
$GLOBALS[ $global ] = null;
}
Expand Down
6 changes: 6 additions & 0 deletions tests/phpunit/tests/comment/getCommentAuthorUrlLink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ class Tests_Comment_GetCommentAuthorUrlLink extends WP_UnitTestCase {

protected static $comments = array();

public function tear_down() {
unset( $GLOBALS['comment'] );

parent::tear_down();
}

public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
unset( $GLOBALS['comment'] );

Expand Down
Loading