Skip to content

Grunt jshint:plugins: Ignore node_modules and common paths for built files. #13207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afercia wants to merge 1 commit into from
+11 −0
Closed

Grunt jshint:plugins: Ignore node_modules and common paths for built files. #13207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,17 @@ module.exports = function(grunt) {
'**/*.js',
'!**/*.min.js'
],
// Prevent traversal into these directories during glob expansion.
// This is much faster than using negation patterns alone.
ignore: [
'**/build/**',
'**/dist/**',
Comment on lines +1072 to +1076

@afercia afercia Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be true as the folders matching these globs are skipped.

'**/gutenberg/**',

@westonruter westonruter Aug 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this technically be redundant since the relevant files in Gutenberg would themselves be ignored by the other globs?

@afercia afercia Aug 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gutenberg contains folders that contain .js files that aren't caught by the other globs, for example:

  • storybook
  • tools

@afercia afercia Aug 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way to double check is: run this command with and without the Gutenberg glob:
grunt jshint:plugins 2>&1 | grep -E "(\/.*\.js)"

without the Gutenberg glob there are a few more Gutenberg directories being scanned.

'**/node_modules/**',
'**/packages/**',
Comment on lines +1075 to +1079
'**/test/**',
'**/vendor/**'
],
/*
* Limit JSHint's run to a single specified plugin directory:
*
Expand Down
Loading