Skip to content

Fix: Submenu arrow position - #13347

Open
3kori wants to merge 4 commits into
WordPress:trunkfrom
3kori:fix/66013-fix-submenu-arrow-position
Open

Fix: Submenu arrow position#13347
3kori wants to merge 4 commits into
WordPress:trunkfrom
3kori:fix/66013-fix-submenu-arrow-position

Conversation

@3kori

@3kori 3kori commented Sep 1, 2026

Copy link
Copy Markdown

Reposition the submenu arrows for smaller screen devices.

Trac ticket: 66013

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props r1k0, sabernhardt, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@3kori

3kori commented Sep 1, 2026

Copy link
Copy Markdown
Author

Before:
Screenshot 2026-09-01 054627

After:
Screenshot 2026-09-01 054117

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment thread src/wp-includes/css/admin-bar.css Outdated
left: 0;
}

#wpadminbar .menupop .menupop > .ab-item .wp-admin-bar-arrow:before {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This has a lower specificity than the selector that includes .ab-top-secondary, so the ruleset could be moved a few lines earlier.

@audrasjb

audrasjb commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR!
Looks almost good to me (see @sabernhardt 's comment above)… but don't you think the arrow is still a bit vertically misaligned?
Capture d’écran 2026-09-01 à 21 57 42

@3kori

3kori commented Sep 1, 2026

Copy link
Copy Markdown
Author

Thank you, @sabernhardt & @audrasjb, for the reviews.
Fixing the specificity.
Lemmi, have another look at the alignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants