Skip to content

Query: Do not replace the posts page with the front page when previewing. - #13364

Open
R1shabh-Gupta wants to merge 1 commit into
WordPress:trunkfrom
R1shabh-Gupta:fix/49969-preview-posts-page-shows-front-page
Open

Query: Do not replace the posts page with the front page when previewing.#13364
R1shabh-Gupta wants to merge 1 commit into
WordPress:trunkfrom
R1shabh-Gupta:fix/49969-preview-posts-page-shows-front-page

Conversation

@R1shabh-Gupta

Copy link
Copy Markdown

When a static front page and a separate posts page are configured, previewing the posts page incorrectly displays the front page.

WP_Query::parse_query() correctly identifies the request as both is_home and is_posts_page. However, in WP_Query::get_posts(), the front page preview logic only checks is_home, which is also true for the posts page. As a result, it replaces the requested page_id with page_on_front.

That behavior is needed when previewing the static front page, since its preview URL is a bare /?preview=true. This change avoids the substitution when the request explicitly targets the posts page.

Steps to reproduce

  1. Create two pages, "My home" and "My posts".
  2. Under Settings → Reading, set the homepage to "My home" and the posts page to
    "My posts".
  3. Edit "My posts" in the block editor.
  4. Click ViewPreview in new tab.

Before this change the preview shows "My home". After it, "My posts".

Trac ticket: https://core.trac.wordpress.org/ticket/49969

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Code Review


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@R1shabh-Gupta
R1shabh-Gupta marked this pull request as ready for review September 2, 2026 10:43
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rishabhwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant