Media: Remove a stray closing div from the Site Icon crop preview template

[i-am-chitti]

Description

Trac ticket: https://core.trac.wordpress.org/ticket/66024

The tmpl-site-icon-preview-crop Backbone template in media-template.php opens three div elements but closes four, leaving an unmatched </div>.

The markup was adapted from the Site Icon preview in options-general.php, which has an extra .direction-wrap wrapper. The wrapper wasn't carried over, but its closing tag was — along with the extra indentation on the .close-button SVG.

This removes the stray tag and dedents the SVG back to a direct child of .site-icon-preview-tab, as its grid-template-columns rule expects.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamchitti, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[mukeshpanchal27]

Introduce in Core-60625 / r58927

[mukeshpanchal27]

Suggested change

	<div class="site-icon-preview-site-title" aria-hidden="true"><# print( '<?php echo esc_js( get_bloginfo( 'name' ) ); ?>' ) #></div>
	<div class="site-icon-preview-site-title" aria-hidden="true">
	<# print( '<?php echo esc_js( get_bloginfo( 'name' ) ); ?>' ) #>
	</div>

[mukeshpanchal27]

Looks good to me.

Left one non blocking feedback