Skip to content

Tests: Add unit test coverage for the network admin action links in WP_Plugins_List_Table::single_row() - #14602

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/plugins-list-table-network-action-links
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/plugins-list-table-network-action-links

Conversation

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Description

Adds tests for the action links that WP_Plugins_List_Table::single_row() builds on the network admin Plugins screen. This follows #14598, which covers a site's Plugins screen.

The tests only run on multisite. They render a row for a temporary plugin, read the links from the network_admin_plugin_action_links filter, and set the dependency state through the static properties of WP_Plugin_Dependencies, which the shared plugin dependencies test case resets. Each test uses its own plugin slug, because single_row() remembers the ID attributes it has used. They cover:

  • the Network Deactivate link of a network-active plugin, and plain text when a network-active plugin requires it;
  • the Network Activate and Delete links of a plugin that is not network active, and no Delete link while it is active on the current site;
  • "Cannot Activate" when the plugin's PHP or WordPress requirement is not met, and plain text for unmet dependencies;
  • plain text instead of the Delete link when other plugins require the plugin, unless the dependency is circular;
  • no links for a site administrator;
  • the network filters receiving the plugin file, data and context, and the site filter not running.

Removing or changing each branch of the network screen links makes at least one test fail.

This is a test-only change; no production code is modified.

Testing Instructions

  1. Run the tests on multisite:
    npm run test:php -- --filter Tests_Admin_wpPluginsListTableNetworkActionLinks -c tests/phpunit/multisite.xml
  2. Run them in random order:
    npm run test:php -- --filter Tests_Admin_wpPluginsListTableNetworkActionLinks -c tests/phpunit/multisite.xml --order-by=random
  3. Run the plugins group on multisite:
    npm run test:php -- --group plugins -c tests/phpunit/multisite.xml
  4. Run PHPCS on the test file:
    node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/wpPluginsListTableNetworkActionLinks.php

Trac ticket: https://core.trac.wordpress.org/ticket/65819

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.

@huzaifaalmesbah
huzaifaalmesbah marked this pull request as ready for review October 21, 2026 03:29
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertions match the source, and CI passes. One note about fixture cleanup inline.

*/
private function get_actions( $plugin_data = array() ) {
$dir = WP_PLUGIN_DIR . '/' . $this->slug;
$this->assertTrue( mkdir( $dir ), 'The test plugin directory should be created.' );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In core tests, WP_PLUGIN_DIR is tests/phpunit/data/plugins, which is a tracked directory. If a run stops partway, such as on a fatal error or Ctrl+C, tear_down() never runs and this fixture folder stays there. The slug comes from a counter that starts at 1 again on the next run, so mkdir() fails on the same folder name. So every test in the class fails here until someone deletes the folder by hand. The leftover also shows up in git status.

Could this helper, or set_up(), remove a leftover folder first? #14600 already does this: its remove_plugin() helper runs in both set_up() and tear_down().

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Added a remove_plugin() helper that clears a leftover folder before mkdir() and in tear_down(), in da49c31. I checked it with a leftover folder in place: the old code failed and the new code passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants