Repository navigation
Conversation
The install, upgrade, and performance test jobs installed WP-CLI through the setup-php `tools` input. setup-php downloads the phar with a single unauthenticated curl call, and when that returns an error it only logs "Could not setup wp-cli" and lets the step pass. The job then fails on the first `wp` command with "command not found". Bursts of these failures have broken most jobs of whole upgrade testing runs. Install WP-CLI in dedicated steps instead. The phar is cached in 6 hour windows, so jobs still pick up new WP-CLI releases without each of them downloading it. A cache miss downloads with curl retries; if that keeps failing, the previous window's phar is used with a warning, and without one the step fails, reporting the error where it happens. PHP 5.4 and 5.5 install jobs keep using WP-CLI 2.4.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs WP-CLI in dedicated steps instead of the
shivammathur/setup-phptoolsinput ininstall-testing.yml,reusable-upgrade-testing.ymlandreusable-performance-test-v2.yml:actions/cachein 6 hour windows (<os>-wp-cli-<version>-<window>), so jobs keep getting the latest WP-CLI without each downloading it.curl --fail --retry 5 --retry-all-errors.restore-keys) is used with a warning; with none, the step fails with an error.setup-php downloads the phar with a single unauthenticated
curl -sL(unix.sh) and on failure only logs✗ wp-cli Could not setup wp-cli, leaving the step green (add_tools.sh). Jobs then fail on the firstwpcommand withwp: command not found(exit 127). The HTTP status is discarded, so the logs don't show the cause; failures come in bursts (22/24 "Upgrade from" jobs in run 38059129117). Other examples: 38055702872, 39166479056.Testing on a fork preview (lucatume/wordpress-develop#29, with the repository guards pointed at the fork):
cURL error 35from downloads.w.org duringwp core update --minor).Trac ticket: TBD
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigating the failures, implementing the change and verifying it on the fork; reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.