Skip to content

REST API: Don't list the data_processing settings in the index. #15183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorgefilipecosta wants to merge 1 commit into from
Closed

REST API: Don't list the data_processing settings in the index. #15183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/wp-includes/rest-api/class-wp-rest-server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,12 +1861,6 @@ public function get_data_for_route( $route, $callbacks, $context = 'view' ) {
$endpoint_data['allow_batch'] = $callback_batch;
}

$data_processing = self::resolve_data_processing( $callback, $route_options );

if ( in_array( false, $data_processing, true ) ) {
$endpoint_data['data_processing'] = $data_processing;
}

if ( isset( $callback['args'] ) ) {
$endpoint_data['args'] = array();

Expand Down
12 changes: 2 additions & 10 deletions tests/phpunit/tests/rest-api/rest-server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3576,7 +3576,7 @@ public function test_data_processing_applies_to_batch_requests(): void {
/**
* @ticket 66372
*/
public function test_data_processing_is_listed_in_the_index(): void {
public function test_data_processing_is_not_listed_in_the_index(): void {
rest_get_server()->register_route(
'test-ns',
'/test-ns/data-processing',
Expand All @@ -3600,15 +3600,7 @@ public function test_data_processing_is_listed_in_the_index(): void {
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();

$this->assertSame(
array(
'fields' => false,
'embed' => true,
'links' => true,
),
$data['endpoints'][0]['data_processing'],
'An endpoint with a feature turned off should list the settings.'
);
$this->assertArrayNotHasKey( 'data_processing', $data['endpoints'][0], 'An endpoint with a feature turned off should not list the settings.' );
$this->assertArrayNotHasKey( 'data_processing', $data['endpoints'][1], 'An endpoint with every feature on should not list the settings.' );
}

Expand Down
Loading