-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade graphiql to v5 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d21c54e
work in progress
raymond-berry 9d8c653
point to public npm registry
berryr0 a1b6a0b
fix tests
berryr0 07f08d5
add publishing and pr check workflows
berryr0 dc191af
add install step to test workflow
berryr0 11f012f
add browser install step to pr checks
berryr0 93eae7c
add pr template
berryr0 aa7f1a3
move graphiql/react and graphiql/toolkit back to peerDependencies
berryr0 a8a62e6
add .npmrc and upgrade lerna
raymond-berry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| ## π Description | ||
|
|
||
| Please include a summary of the changes and the related issue. Be concise but clear. | ||
|
|
||
| > Example: "Fixes #42 - Updates the linter config and resolves formatting issues." | ||
|
|
||
| --- | ||
|
|
||
| ## π Changes Made | ||
|
|
||
| - [ ] Brief bullet-point list of changes | ||
| - [ ] Highlight **key files or logic updated** | ||
| - [ ] Mention **any breaking changes** or impacts | ||
|
|
||
| --- | ||
|
|
||
| ## π§ͺ Testing | ||
|
|
||
| - [ ] Tested locally | ||
| - [ ] Unit tests updated/added | ||
| - [ ] CI pipeline passed (lint, tests) | ||
|
|
||
| Describe **how you tested the changes** and any edge cases considered. | ||
|
|
||
| --- | ||
|
|
||
| ## π· Screenshots (if UI-related) | ||
|
|
||
| > Add screenshots or GIFs showing before/after, if applicable. | ||
|
|
||
| --- | ||
|
|
||
| ## β Checklist | ||
|
|
||
| Please confirm all items are complete before requesting a review: | ||
|
|
||
| - [ ] I have run `lint` and fixed any issues | ||
| - [ ] I have run all existing tests and they pass | ||
| - [ ] I have added tests for new code (if needed) | ||
| - [ ] I have documented my changes (if needed) | ||
| - [ ] Linked relevant issues in the PR description | ||
|
|
||
| --- | ||
|
|
||
| ## π£ Reviewer Notes | ||
|
|
||
| > Is there anything youβd like reviewers to focus on, or any context thatβs useful for them? | ||
|
|
||
| --- | ||
|
|
||
| Thank you for your contribution! π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Pull Request Checks | ||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout π | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Node βοΈ | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' # Todo use our .nvmrc instead | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - name: Install dependencies and build π§ | ||
| run: npm run setup && npm run build | ||
| - name: Lint Code π§Ή | ||
| run: npm run lint | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout π | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Node βοΈ | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' # Todo use our .nvmrc instead | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - name: Release build ποΈ | ||
| run: npm run setup && npm run release | ||
| - name: Install Browsers π | ||
| run: npx playwright install --with-deps | ||
| - name: Tests π§ͺ | ||
| run: npm run test | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Publish to NPM | ||
| on: | ||
| release: | ||
| types: [created] | ||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout π | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Node βοΈ | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' # Todo use our .nvmrc instead | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - name: Install dependencies and build π§ | ||
| run: npm run setup && npm run release | ||
| - name: Publish package on NPM π¦ | ||
| run: npm run publish:npm | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.PUBLISH_TO_NPM_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| registry=https://registry.npmjs.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,13 +38,6 @@ module.exports = { | |
| ] | ||
| }, | ||
| resolve: { | ||
| // make sure we get the same libraries even if we symlink in dependencies | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed this because it was causing errors when running dev for me. It was causing dev to keep looking at incorrect dependency after the version was upgraded. |
||
| alias: { | ||
| '@graphiql/react': path.resolve(__dirname, '../node_modules/@graphiql/react'), | ||
| graphql: path.resolve(__dirname, '../node_modules/graphql'), | ||
| react: path.resolve(__dirname, '../node_modules/react'), | ||
| 'react-dom': path.resolve(__dirname, '../node_modules/react-dom') | ||
| }, | ||
| // graphql can accidentally be imported in 2 ways if we don't have this | ||
| // https://stackoverflow.com/a/52635917/6079700 | ||
| extensions: ['.tsx', '.ts', '.mjs', '.js'] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.