Repository navigation
style(nav-rail): enhance reorder icon visibility and placement - #518
Conversation
- Increase drag‑handle font size to 14px. - Use primary theme color for the icon. - Add background using token.colorBgContainer. - Apply border radius, padding, and centered flex alignment. - Improves contrast and discoverability in both light and dark themes.
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe nav rail drag handle now uses a 14px icon in the theme’s primary color. It has a container background, a small theme-based border radius, and 2px padding. Its contents are centered. ChangesNav rail drag handle
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The changes are limited to the navigation drag handle’s appearance and alignment; no actionable merge risk is identified from the supplied context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chamikaJ
left a comment
There was a problem hiding this comment.
Thanks for the focused visibility improvement. The theme-aware foreground and background token choices look good, and the CI/security checks are passing.\n\nPlease replace the hardcoded with the appropriate Ant Design radius token (for example ) so the handle remains aligned with the product design system if token values change. Once that is updated, this is good to merge.
|
Clarification to the requested change: replace the hardcoded borderRadius: 4 with token.borderRadiusSM. |
chamikaJ
left a comment
There was a problem hiding this comment.
Re-reviewed the follow-up commit: the drag handle now uses token.borderRadiusSM, preserving design-token consistency. The focused visual change is safe and all CI and security checks are passing.
Summary by CodeRabbit