Show relative timestamps in trade history - #12
Open
john-a-zoidburg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5m ago,3h ago,2d ago) instead of exposing the less immediately useful block number.Why
Trade timestamps answer the question most visitors have—“when did this happen?”—without requiring them to interpret a block height. The Counterparty match data and launch-room payload already carry each trade's block timestamp, so this is a presentation-only change with no additional requests or backend work.
The table also had a 43rem minimum width inside a 42rem section, which guaranteed a small horizontal scrollbar on desktop. Lowering the table's minimum to 41rem lets
w-fullmatch the section while preserving horizontal scrolling on narrow screens.Screenshots
Before — block numbers and slight horizontal overflow
After — relative trade ages and corrected width
Verification
npm run check— 200 tests plus web/API TypeScript, ESLint, and numeric-discipline checksnpm run build --workspace apps/web