test: Add tests for TMProofPathResponse and TMReplayDeltaResponse invalid hash/key sizes#7593
Open
mathbunnyru wants to merge 6 commits into
Open
test: Add tests for TMProofPathResponse and TMReplayDeltaResponse invalid hash/key sizes#7593mathbunnyru wants to merge 6 commits into
mathbunnyru wants to merge 6 commits into
Conversation
…alid hash/key sizes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7593 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.0%
=========================================
Files 1007 1007
Lines 76890 76891 +1
Branches 8976 8971 -5
=========================================
Hits 63049 63049
- Misses 13832 13833 +1
Partials 9 9 see 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
godexsoft
previously approved these changes
Jun 26, 2026
godexsoft
left a comment
godexsoft
left a comment
Contributor
There was a problem hiding this comment.
Approving but there is a question 
| { | ||
| testcase("base_uint: general purpose tests"); | ||
|
|
||
| #ifdef NDEBUG |
Contributor
Author
There was a problem hiding this comment.
Maybe not anymore, let's try to remove it
Update: yes, it's needed, we can't guarantee that the data will be 0 in Debug builds. I know it's not great, but this PR is a test only, so if it needs to be improved, it should be done separately.
This reverts commit 9dfe083.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The change was implemented in 3.1.3, so let's add a test for it.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)