fix: Block delegate tx from being queued#7640
Merged
Merged
Conversation
bb09077 to
d1e01dd
Compare
shawnxie999
reviewed
Jun 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7640 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.0%
=========================================
Files 1007 1007
Lines 76890 76890
Branches 8976 8972 -4
=========================================
- Hits 63049 63040 -9
- Misses 13832 13841 +9
Partials 9 9
🚀 New features to boost your workflow:
|
ximinez
previously approved these changes
Jun 26, 2026
ximinez
left a comment
Collaborator
There was a problem hiding this comment.
Other than adding the test @shawnxie999 asked for, this looks good.
shawnxie999
approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents delegated transactions (those with sfDelegate present) from being admitted into the transaction queue (TxQ), while still allowing them to apply directly to the open ledger when they pay the required open-ledger fee.
Changes:
- Add a TxQ eligibility check that rejects any transaction containing
sfDelegatefrom being queued (telCAN_NOT_QUEUE). - Add a unit test that verifies delegated transactions cannot be queued, but can still succeed when submitted with the open-ledger fee.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/xrpld/app/misc/detail/TxQ.cpp | Rejects delegated transactions in TxQ::canBeHeld() so they can’t enter TxQ. |
| src/test/app/TxQ_test.cpp | Adds coverage ensuring delegated txs are rejected from TxQ but still succeed with sufficient fee. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bthomee
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
delegate tx is disallowed to enter txQ
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)