feat(desktop): skip login; model setup then first chat - #86
Merged
Merged
Conversation
XYAIStudio
marked this pull request as ready for review
September 20, 2026 13:56
Desktop first launch no longer requires registration. The first screen is optional model setup (cloud key or local Ollama, skippable). Skip or save opens a conversation with the default assistant instead of the workspace list. Returning users with providers or a finished onboarding flag are not sent through the wizard again. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
Stop the desktop local-session retry loop from touching window after the login page unmounts, which was failing the first-run tests. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
cursor
Bot
force-pushed
the
cursor/desktop-skip-login-first-chat-ebaf
branch
from
September 20, 2026 15:30
91dbc3b to
5a4804d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop first-run no longer requires registration or login. After launch, the first screen is optional model setup (cloud API key or local Ollama). Skip or save then opens a conversation with the default first agent (
/chat/main), not the workspace conversation list.Existing users who already have providers or have skipped/saved this step are not sent through the wizard again.
Rebased onto
mainafter #85 squash-merge. CHANGELOG Unreleased keeps both the security note (no packaged/prefilled cloud keys) and this first-run UX entry. No installers, no merge from this PR.Target branch
develop(feature / fix — default)main(requested product UX on the shipping desktop tree)Type of change
Before / after
Before: guest session could skip a login form, but first-run still dumped into
/chat→ conversation list (/projects), and the setup “already done” check compared against/chat(never matched/projects), so returning users could loop on model setup.After:
main)Optional account claiming stays in the avatar menu for save/export/org room. Organization login remains a separate door.
Test plan
mainafter security: remove embedded DeepSeek API keys; require user/local model setup #85desktopOnboarding,AuthGuard,SetupPage,LoginPage)cd dashboard && npm test -- src/utils/desktopOnboarding.test.ts src/components/AuthGuard.test.tsx src/pages/Setup/index.test.tsx src/pages/Login/index.test.tsx→ 18 passedChecklist
CHANGELOG.md(Unreleased: security + first-run UX)Intentional leftovers