Security: Hardcoded Database Path in Drizzle Config#882
Closed
tuanaiseo wants to merge 11 commits into
Closed
Conversation
docs: correct OpenCode repository URL in README files
…-qrcode docs: update community group chat QR code
…-qrcode docs: update community WeChat QR codes
The drizzle.config.ts file contains a hardcoded absolute database path '/home/thdxr/.local/share opencode/opencode.db' in the dbCredentials.url field. This exposes a developer's personal system path and will cause failures when deployed or used on other machines. The path should be configurable via environment variables. Affected files: drizzle.config.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The drizzle.config.ts file contains a hardcoded absolute database path '/home/thdxr/.local/share opencode/opencode.db' in the dbCredentials.url field. This exposes a developer's personal system path and will cause failures when deployed or used on other machines. The path should be configurable via environment variables.
Severity:
mediumFile:
packages/opencode/drizzle.config.tsSolution
Replace the hardcoded path with an environment variable fallback, e.g.,
url: process.env.DATABASE_URL ?? './opencode.db'Changes
packages/opencode/drizzle.config.ts(modified)Testing