Add AIE dtrace INI getters for L2-L2 memtile metrics - #10009
Conversation
Signed-off-by: predutta <predutta@amd.com>
There was a problem hiding this comment.
Pull request overview
This PR adds new config_reader.h accessors intended to allow xrt.ini to specify additional AIE dtrace (aie_dtrace) settings related to memory-tile metrics, including l2-l2 design points.
Changes:
- Added
get_aie_dtrace_settings_tile_based_memory_tile_metrics()string getter. - Added
get_aie_dtrace_settings_l2_l2_design_points()string getter.
Suppressed comments (1)
src/runtime_src/core/common/config_reader.h:1028
get_aie_dtrace_settings_l2_l2_design_points()is not referenced anywhere in this repo, soAIE_dtrace_settings.l2_l2_design_pointscurrently has no effect. If this PR is meant to enable l2-l2 memtile metrics from xrt.ini, please add the corresponding consumer logic (or update the PR description/scope).
inline std::string
get_aie_dtrace_settings_l2_l2_design_points()
{
static std::string value =
detail::get_string_value("AIE_dtrace_settings.l2_l2_design_points", "");
return value;
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Please sign off |
Align config_reader with the updated AIE_dtrace_settings key used for memtile halo port design points in xrt.ini. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: predutta <predutta@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, consistent addition of two config getters and does not introduce behavioral risk within XRT beyond exposing new key reads.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
clang-tidy review says "All clean, LGTM! 👍" |
Problem solved by the commit
Enabling l2-l2 (memtile level) aie_dtrace from xrt.ini
What has been tested and how, request additional testing if necessary
Tested on telluride board, on a baseline overlay design.