Skip to content

Add AIE dtrace INI getters for L2-L2 memtile metrics - #10009

Merged
jvillarre merged 2 commits into
Xilinx:masterfrom
predutta:l2l2dtrace
Sep 8, 2026
Merged

jvillarre merged 2 commits into
Xilinx:masterfrom
predutta:l2l2dtrace

Conversation

@predutta

Copy link
Copy Markdown
Collaborator

Problem solved by the commit

Enabling l2-l2 (memtile level) aie_dtrace from xrt.ini

What has been tested and how, request additional testing if necessary

Tested on telluride board, on a baseline overlay design.

Signed-off-by: predutta <predutta@amd.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new config_reader.h accessors intended to allow xrt.ini to specify additional AIE dtrace (aie_dtrace) settings related to memory-tile metrics, including l2-l2 design points.

Changes:

  • Added get_aie_dtrace_settings_tile_based_memory_tile_metrics() string getter.
  • Added get_aie_dtrace_settings_l2_l2_design_points() string getter.
Suppressed comments (1)

src/runtime_src/core/common/config_reader.h:1028

  • get_aie_dtrace_settings_l2_l2_design_points() is not referenced anywhere in this repo, so AIE_dtrace_settings.l2_l2_design_points currently has no effect. If this PR is meant to enable l2-l2 memtile metrics from xrt.ini, please add the corresponding consumer logic (or update the PR description/scope).
inline std::string
get_aie_dtrace_settings_l2_l2_design_points()
{
  static std::string value =
      detail::get_string_value("AIE_dtrace_settings.l2_l2_design_points", "");
  return value;
}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/runtime_src/core/common/config_reader.h
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@stsoe

stsoe commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Please sign off git commit -s --amend --no-edit

Align config_reader with the updated AIE_dtrace_settings key used for
memtile halo port design points in xrt.ini.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: predutta <predutta@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, consistent addition of two config getters and does not introduce behavioral risk within XRT beyond exposing new key reads.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jvillarre
jvillarre merged commit e2f0734 into Xilinx:master Sep 8, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants