Fix Binskim BA6004 Eliminate Duplicate Strings issue for debug builds#9767
Merged
stsoe merged 1 commit intoXilinx:masterfrom May 1, 2026
Merged
Fix Binskim BA6004 Eliminate Duplicate Strings issue for debug builds#9767stsoe merged 1 commit intoXilinx:masterfrom
stsoe merged 1 commit intoXilinx:masterfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Yvonne Yang <Yvonne.Yang@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://amd.atlassian.net/browse/EDGEML-13495 and https://amd.atlassian.net/browse/EDGEML-13496 reported BA6002 (EliminateDuplicateStrings) warning in debug builds of cert_dtrace.dll, xrtcore and xdp dlls.,
How problem was solved, alternative solutions (if any) and why they were rejected
Added /GF flag for debug builds as it is safe and does not conflict with any Debug-only flags.
What has been tested and how, request additional testing if necessary
Build both Release and Debug xrt successfully without any warnings.