style: clean log for fast sync#2379
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| snap, err := x.getSnapshot(chain, h.Number.Uint64(), false) | ||
| if err != nil { | ||
| log.Warn("[getEpochSwitchInfo] Adaptor v2 getSnapshot has error, cannot get standbynodes", "err", err) | ||
| log.Debug("[getEpochSwitchInfo] Adaptor v2 getSnapshot has error, cannot get standbynodes, most probably in fast syncing", "err", err) |
There was a problem hiding this comment.
WIP: we can keep the Warn. we can add a condition about whether this node is a fast sync node. If fast sync node, cannot get standbynodes is not a warn. we can even skip the log
4 participants
Proposed changes
clean log for fast sync, especially error log.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that