Skip to content

[Domain] 마이페이지용 Repository/UseCase 추가 - #46

Merged
Moony-H merged 4 commits into
feature/44-create-my-pagefrom
feature/create-repository-and-usecase
Aug 1, 2026
Merged

[Domain] 마이페이지용 Repository/UseCase 추가#46
Moony-H merged 4 commits into
feature/44-create-my-pagefrom
feature/create-repository-and-usecase

Conversation

@Moony-H

@Moony-H Moony-H commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

관련 이슈

작업 내용

마이페이지에서 유저 정보와 사주팔자 정보를 조회/조합하기 위한 Repository 인터페이스와 UseCase를 추가했습니다.

변경사항 / 상세

  • SajuRepository: getSajuPalja(): Result<SajuPalja>
  • GetUserUseCase: UserRepository 위임
  • GetSajuPaljaUseCase: SajuRepository 위임
  • GetMyPageInfoUseCase: 위 두 UseCase를 합성하는 퍼사드. MyPageInfo(User + SajuPalja)를 반환하며, 하나라도 실패하면 즉시 실패 처리
    • MyPageInfo는 이 UseCase에서만 쓰여 별도 model 파일로 분리하지 않고 GetMyPageInfoUseCase.kt에 함께 정의

중점 리뷰사항

  • GetMyPageInfoUseCase의 실패 처리가 "하나라도 실패하면 전체 실패"인데, 부분 실패 허용(예: 사주 계산 실패해도 유저 정보는 표시)이 필요한지 기획 확인 필요
  • MyPageInfo를 usecase 파일에 함께 둔 것이 적절한지 (재사용 필요해지면 model/mypage/로 분리 예정)

스크린샷 (선택)

N/A (domain 레이어 전용 변경)

Moony-H added 3 commits July 31, 2026 17:41
* feat: add GetUserUseCase and GetSajuPaljaUseCase
* feat: add GetMyPageInfoUseCase to aggregate user and saju information
* reformat constructors and indentation for domain use cases
* update formatting in SajuRepository
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a77f7fad-24dd-4cf4-8772-f3a5f60a11a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Moony-H
Moony-H marked this pull request as draft July 31, 2026 09:02
@Moony-H Moony-H self-assigned this Jul 31, 2026
@Moony-H
Moony-H requested a review from oungsi2000 July 31, 2026 09:06
@Moony-H
Moony-H marked this pull request as ready for review July 31, 2026 09:06
Base automatically changed from feature/my-page-domain-model to feature/44-create-my-page July 31, 2026 09:17
* feat: parallelize data fetching in GetMyPageInfoUseCase using async
* chore: add kotlinx-coroutines-core dependency to core:domain module
@Moony-H
Moony-H merged commit 6d9888d into feature/44-create-my-page Aug 1, 2026
3 checks passed
@Moony-H
Moony-H deleted the feature/create-repository-and-usecase branch August 1, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants