[Domain] 마이페이지용 Repository/UseCase 추가 - #46
Merged
Moony-H merged 4 commits intoAug 1, 2026
Conversation
* feat: add GetUserUseCase and GetSajuPaljaUseCase * feat: add GetMyPageInfoUseCase to aggregate user and saju information
* reformat constructors and indentation for domain use cases * update formatting in SajuRepository
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Moony-H
marked this pull request as draft
July 31, 2026 09:02
Moony-H
marked this pull request as ready for review
July 31, 2026 09:06
Base automatically changed from
feature/my-page-domain-model
to
feature/44-create-my-page
July 31, 2026 09:17
* feat: parallelize data fetching in GetMyPageInfoUseCase using async * chore: add kotlinx-coroutines-core dependency to core:domain module
oungsi2000
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
마이페이지에서 유저 정보와 사주팔자 정보를 조회/조합하기 위한 Repository 인터페이스와 UseCase를 추가했습니다.
변경사항 / 상세
SajuRepository:getSajuPalja(): Result<SajuPalja>GetUserUseCase:UserRepository위임GetSajuPaljaUseCase:SajuRepository위임GetMyPageInfoUseCase: 위 두 UseCase를 합성하는 퍼사드.MyPageInfo(User+SajuPalja)를 반환하며, 하나라도 실패하면 즉시 실패 처리MyPageInfo는 이 UseCase에서만 쓰여 별도 model 파일로 분리하지 않고GetMyPageInfoUseCase.kt에 함께 정의중점 리뷰사항
GetMyPageInfoUseCase의 실패 처리가 "하나라도 실패하면 전체 실패"인데, 부분 실패 허용(예: 사주 계산 실패해도 유저 정보는 표시)이 필요한지 기획 확인 필요MyPageInfo를 usecase 파일에 함께 둔 것이 적절한지 (재사용 필요해지면model/mypage/로 분리 예정)스크린샷 (선택)
N/A (domain 레이어 전용 변경)