Conversation
Very inspired by https://github.com/ghostty-org/ghostty/blob/main/AI_POLICY.md which I found quite resonating with my opinions of the topic, after dealing with recent AI generated PRs. Thoughts? Next steps: - fine tuning / rewording - linking from CONTRIBUTING.md - while we are at it, maybe shortening that CONTRIBUTING.md page which is very wordy and covering stuff that are included in issues/PR templates.
dgw
left a comment
There was a problem hiding this comment.
Figured we should focus on this first, then look at changes to CONTRIBUTING separately once the AI policy is more or less finished.
Co-authored-by: dgw <dgw@technobabbl.es>
s/ 🇫🇷 / 🇺🇸 /g
Added a section on the necessity for Pull Requests to originate from real human needs.
|
Thanks for reviewing and improving @dgw 👍 Added a new paragraph to express the feeling I shared to the latest dude with all the PRs -- if a PR doesn't come from a real human need, we probably don't need it. Also : as usual, I have no f*ing clue about what's needed to please the linter. |
LeoColomb
left a comment
There was a problem hiding this comment.
Big 👍 here!
Some comments inline, mostly cosmetics.
Two additional remarks:
- As I noted inline, security-related AI scanning might be something to consider differently. I don't know how to write this, especially since we already have a security policy, but I wanted to highlight this might be an important topic.
- I also don't know how much it would be relevant or how to phrase it correctly, but I'd be happy if one section points out submitting PR is not enough, and maintainers comments should be taken into consideration. Said differently, following up on submitted PR is as important. (if that makes sense?)
Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com>
I've added a note -- anyone feel free to reword
Valid point, probably more suited in the PR template. To me it goes along with "just to make sure, maybe ask everyone before working on adding a new feature" |
Migrated to Linux a couple weeks ago. Disk drive died, had this in mind for a long time, so I figured it was the right moment to do so. So, no, 100% working on Linux now, I don't get where that CRLF came from. Still tweaking my setup here and there but I'm getting close ;) |
|
@ozh The formatting is all good now, yes! I hope you don't mind me committing here, I've disabled Biome (and Zizmor) here so it does not complain anymore. I feel terrible hijacking this PR for that 😅. |
|
Incoming: A couple more code-review tweaks from my second look at the new document. :)
This is relevant in the general It's implied by the bullet I suggested before ("The human-in-the-loop must communicate with maintainers."), as well, but mentioning it in both contexts works. Even a note in the PR template, reminding people, can't hurt.
Don't feel bad, it's the quicker alternative to submitting a separate PR for tweaking the linter settings, merging that, then integrating those upstream changes into this branch. Assuming we will squash-merge as usual, it won't make the history any messier. 😸 |
Co-authored-by: dgw <dgw@technobabbl.es>
|
Crazy: line endings are OK, then I commit through Github interface dgw's suggestions, and line endings are NOK again. Not saying it's useful to check line ending 🙄 😁 but I don't get why. |
|
AI Policy OK for me here -- any rewording welcome of course. Now proposing a rewrite of the CONTRIBUTING and a PR template. I made them as short and concise as possible -- not a manual on "how to use Git and PR on Github", I think our .md files as of now are somewhat too verbose. |

Very inspired by https://github.com/ghostty-org/ghostty/blob/main/AI_POLICY.md which I found quite resonating with my opinions on the topic, after dealing with recent AI generated PRs.
Thoughts?
Next steps: