feat: install the platform with a Helm chart built from the manifests - #38
Merged
Merged
Conversation
Generate deploy/helm/llm-routing from the reviewed manifests, lifting out image references, namespace, gateway scale and the serving topology. Tests render it with helm and compare it with kustomize in both modes; CD fails on a stale chart, lints it, and packages it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Helm chart the spec's deployment topology calls for (§17: "Docker, Kubernetes, Helm and GitHub Actions").
How
llm_router.chartbuildsdeploy/helm/llm-routingfrom the reviewed manifests instead of duplicating them by hand. It lifts out only what an installation changes:serving.modevllm(one engine) orray(the Ray Serve overlay)images.*gateway.replicas,gateway.autoscaling.*The namespace becomes the release namespace, and Prometheus templating in alert annotations is escaped so Helm passes it through. The chart owns no
Namespace.CD now fails if the committed chart is stale, lints it, and packages it as an artifact.
Tests
tests/unit/test_chart.py(11 tests). The important ones render the chart with realhelm templateand compare it, resource by resource, with realkubectl kustomize:serving.mode=rayrenders exactly the Ray overlay;These need
helmandkubectl; they skip on a workstation without them and fail in CI if the tools are missing.Local: ruff and mypy clean, 400 tests pass, 98% coverage.
Limits
versionandappVersioncome frompyproject.toml, which still says0.1.0while release tags are atv0.10.x; aligning them is a separate change.🤖 Generated with Claude Code