Bump to 3.0.2 and drop Homebrew deprecation-shim formula#13
Open
manuelgruber wants to merge 3 commits into
Open
Bump to 3.0.2 and drop Homebrew deprecation-shim formula#13manuelgruber wants to merge 3 commits into
manuelgruber wants to merge 3 commits into
Conversation
Refresh Cargo.lock to the latest semver-compatible versions of cc, clap_complete, hashbrown, tokio, and zerofrom to pick up upstream bugfixes and security patches. Bump clap_mangen from 0.2 to 0.3. The wrapper in src/bin/gen_manpage.rs uses only Man::new + render, both unchanged in 0.3, so no code edits were needed. Verified end-to-end by regenerating the manpage and shell completions under --features release-tools.
…-same-cli The shim was a transitional formula that depended on git-same-cli and emitted a deprecation warning. Removing it now since the cask + CLI formula cover both audiences (macOS GUI users and Linux/headless). Note: the published Formula/git-same.rb in zaai-com/homebrew-tap is not removed by this change; it needs a manual git rm in the tap repo after S3 next runs.
Reviewer's GuideBumps git-same to 3.0.2 with refreshed dependencies, upgrades clap_mangen, and simplifies the Homebrew toolkit by dropping the legacy git-same deprecation shim formula, consolidating scripts and workflows around a single git-same-cli formula plus cask, and updating docs and release checklist accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
WalkthroughThis PR removes the deprecated Homebrew formula-shim from the entire publishing pipeline. The shim template file is deleted, rendering and verification scripts are simplified to remove ChangesFormula Rendering and Verification Simplification
Publishing Workflow Integration
Documentation and Manifest Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/S3-Publish-Homebrew.yml (1)
107-125:⚠️ Potential issue | 🟠 Major | ⚡ Quick winLegacy shim formula is never removed from the tap.
This workflow stages updates for two files but does not delete/stage removal of
Formula/git-same.rb, so the deprecated shim can remain published even after this PR.Suggested fix
- name: Stage rendered files into tap run: | mkdir -p tap/Formula tap/Casks cp formula-cli.rb "tap/Formula/${FORMULA_NAME}.rb" cp cask.rb "tap/Casks/${CASK_NAME}.rb" + rm -f "tap/Formula/git-same.rb" - name: Commit and push to tap run: | cd tap git config user.name "github-actions[bot]" git config user.email "github-actions[bot]@users.noreply.github.com" - git add \ - "Formula/${FORMULA_NAME}.rb" \ - "Casks/${CASK_NAME}.rb" + git add -A "Formula" "Casks" if git diff --cached --quiet; then echo "Cask + formula unchanged, skipping commit" else git commit -m "Update git-same to ${{ steps.version.outputs.version }} (cask + formula-cli)" git push origin HEAD fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/S3-Publish-Homebrew.yml around lines 107 - 125, The workflow stages new formula and cask but never removes the legacy shim Formula/git-same.rb; update the "Stage rendered files into tap" / "Commit and push to tap" steps so the job also removes and stages deletion of the legacy file (e.g., ensure Formula/git-same.rb is deleted if present before committing). Specifically, after copying formula-cli.rb and cask.rb (the FORMULA_NAME and CASK_NAME targets), add a step to remove Formula/git-same.rb when it exists and ensure the git add/git commit stage will include that deletion so the deprecated shim is removed from the tap on push.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/S3-Publish-Homebrew.yml:
- Around line 107-125: The workflow stages new formula and cask but never
removes the legacy shim Formula/git-same.rb; update the "Stage rendered files
into tap" / "Commit and push to tap" steps so the job also removes and stages
deletion of the legacy file (e.g., ensure Formula/git-same.rb is deleted if
present before committing). Specifically, after copying formula-cli.rb and
cask.rb (the FORMULA_NAME and CASK_NAME targets), add a step to remove
Formula/git-same.rb when it exists and ensure the git add/git commit stage will
include that deletion so the deprecated shim is removed from the tap on push.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8564c4eb-ff8b-49e0-8996-d964f9bceaf6
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.github/workflows/S3-Publish-Homebrew.ymlCargo.tomldocs/README.mdtoolkit/homebrew/README.mdtoolkit/homebrew/formula-shim.rb.tmpltoolkit/homebrew/render-formula.shtoolkit/homebrew/verify-tap.shtoolkit/packaging/release-checklist.md
💤 Files with no reviewable changes (1)
- toolkit/homebrew/formula-shim.rb.tmpl
There was a problem hiding this comment.
Pull request overview
This PR updates the crate to 3.0.2 (including dependency refreshes like clap_mangen → 0.3) and simplifies the Homebrew tap/tooling by removing the legacy git-same deprecation-shim formula so the tap ships only the cask (git-same) and the CLI formula (git-same-cli).
Changes:
- Bump crate version to 3.0.2 and refresh dependencies (notably
clap_mangento 0.3). - Remove the Homebrew deprecation-shim formula and update scripts/docs accordingly (
render-formula.sh,verify-tap.sh, README/checklist). - Simplify the S3 Homebrew publishing workflow to render/verify/publish only the cask and CLI formula.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| toolkit/packaging/release-checklist.md | Updates release steps to reflect the removal of the shim formula. |
| toolkit/homebrew/verify-tap.sh | Drops shim handling and verifies only cask + CLI formula; keeps brew style compatible with current Homebrew. |
| toolkit/homebrew/render-formula.sh | Removes --kind and shim rendering; always renders the CLI formula template. |
| toolkit/homebrew/README.md | Updates documentation and local smoke steps for the slimmer tap layout. |
| toolkit/homebrew/formula-shim.rb.tmpl | Deletes the deprecated shim formula template. |
| docs/README.md | Removes outdated note about the deprecated macOS formula path now that the shim is gone. |
| Cargo.toml | Bumps version to 3.0.2 and updates clap_mangen dependency to 0.3. |
| Cargo.lock | Updates lockfile to match the version bump and dependency refreshes. |
| .github/workflows/S3-Publish-Homebrew.yml | Simplifies S3 publishing to render/verify/publish only cask + CLI formula (no shim). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the crate to 3.0.2, refreshes dependencies, and moves
clap_mangento 0.3 to pick up upstream fixes. Drops the legacygit-samedeprecation-shim Homebrew formula so the tap now ships only the cask and thegit-same-cliformula. Simplifiesrender-formula.sh,verify-tap.sh, the S3-Publish-Homebrew workflow, and the toolkit README to match the slimmer tap layout. Also drops--strictfrom the earlierbrew stylecall so the S3 verify-tap step works on current Homebrew.Summary by Sourcery
Drop the legacy Homebrew deprecation shim and streamline Homebrew tooling while bumping the git-same crate and dependencies.
Enhancements:
CI:
Documentation:
Chores:
Summary by CodeRabbit
Changes
brew upgrade --cask git-same.Documentation
Chores