fix: rename inv_mul_cancel to inv_mul_cancel₀ in Level 8 (closes #21)#22
Merged
Conversation
The TheoremDoc and NewTheorem declarations advertised `inv_mul_cancel h` for proving `x⁻¹ * x = 1` from `h : x ≠ 0`, but in current mathlib that is `inv_mul_cancel₀` (the GroupWithZero version). Plain `inv_mul_cancel` is the group version and takes no hypothesis, so following the docs failed type-checking. Also simplifies the helper lemma's internal proof to use `inv_mul_cancel₀` directly instead of the indirect `mul_eq_one_iff_eq_inv₀` rewrite. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TheoremDoc and NewTheorem declarations advertised
inv_mul_cancel hfor provingx⁻¹ * x = 1fromh : x ≠ 0, but in current mathlib that isinv_mul_cancel₀(the GroupWithZero version). Plaininv_mul_cancelis the group version and takes no hypothesis, so following the docs failed type-checking. Also simplifies the helper lemma's internal proof to useinv_mul_cancel₀directly instead of the indirectmul_eq_one_iff_eq_inv₀rewrite.